New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: document that readline write() is processed as input #8295

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@jasnell
Member

jasnell commented Aug 27, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Document that data written using readline.write() is processed as input.

Fixes: #4402

@addaleax

This comment has been minimized.

Show comment
Hide comment
@addaleax

addaleax Aug 27, 2016

Member

LGTM

Member

addaleax commented Aug 27, 2016

LGTM

@mscdex

This comment has been minimized.

Show comment
Hide comment
@mscdex

mscdex Aug 27, 2016

Contributor

Commit message is too long.

Contributor

mscdex commented Aug 27, 2016

Commit message is too long.

@mscdex

View changes

Show outdated Hide outdated doc/api/readline.md Outdated
@cjihrig

This comment has been minimized.

Show comment
Hide comment
@cjihrig

cjihrig Aug 27, 2016

Contributor

LGTM pending the nit.

Contributor

cjihrig commented Aug 27, 2016

LGTM pending the nit.

jasnell added a commit that referenced this pull request Aug 29, 2016

doc: readline write() is processed as input
Fixes: #4402
PR-URL: #8295
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Aug 29, 2016

Member

Landed in 61fa50d

Member

jasnell commented Aug 29, 2016

Landed in 61fa50d

@jasnell jasnell closed this Aug 29, 2016

@Fishrock123 Fishrock123 referenced this pull request Sep 6, 2016

Closed

v6.6.0 pre-proposal #8428

Fishrock123 added a commit to Fishrock123/node that referenced this pull request Sep 8, 2016

doc: readline write() is processed as input
Fixes: nodejs#4402
PR-URL: nodejs#8295
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Fishrock123 added a commit that referenced this pull request Sep 9, 2016

doc: readline write() is processed as input
Fixes: #4402
PR-URL: #8295
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins added a commit that referenced this pull request Sep 30, 2016

doc: readline write() is processed as input
Fixes: #4402
PR-URL: #8295
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins added a commit that referenced this pull request Oct 10, 2016

doc: readline write() is processed as input
Fixes: #4402
PR-URL: #8295
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

rvagg added a commit that referenced this pull request Oct 18, 2016

doc: readline write() is processed as input
Fixes: #4402
PR-URL: #8295
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins added a commit that referenced this pull request Oct 26, 2016

doc: readline write() is processed as input
Fixes: #4402
PR-URL: #8295
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

@MylesBorins MylesBorins referenced this pull request Oct 26, 2016

Closed

V4.6.2 proposal #9298

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment