New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test for zlib.create*Raw() #8306

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@Trott
Member

Trott commented Aug 28, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test zlib

Description of change

Currently, there are no tests that exercise zlib.createInflateRaw() or
zlib.createDeflateRaw().

This adds minimal tests that invoke the functions and confirm that they
return zlib.InflateRaw/zlib.DeflateRaw objects.

test: add test for zlib.create*Raw()
Currently, there are no tests that exercise `zlib.createInflateRaw()` or
`zlib.createDeflateRaw()`.

This adds minimal tests that invoke the functions and confirm that they
return `zlib.InflateRaw`/`zlib.DeflateRaw` objects.

@Trott Trott added zlib test labels Aug 28, 2016

@Trott

This comment has been minimized.

Show comment
Hide comment
@addaleax

This comment has been minimized.

Show comment
Hide comment
@addaleax

addaleax Aug 28, 2016

Member

CI is green, LGTM

Member

addaleax commented Aug 28, 2016

CI is green, LGTM

{
const deflateRaw = zlib.createDeflateRaw();
assert(deflateRaw instanceof zlib.DeflateRaw);
}

This comment has been minimized.

@Fishrock123

Fishrock123 Aug 28, 2016

Member

are these necessary?

@Fishrock123

Fishrock123 Aug 28, 2016

Member

are these necessary?

This comment has been minimized.

@Trott

Trott Aug 28, 2016

Member

You mean the scoping braces? No, not strictly necessary, but desirable IMO. Having every test in its own scope means (among other benefits) that you can freely add and remove variables in one test without worrying about side effects in any of the other tests. Right now, there's only two tests in this file but ideally more tests will be added over time.

@Trott

Trott Aug 28, 2016

Member

You mean the scoping braces? No, not strictly necessary, but desirable IMO. Having every test in its own scope means (among other benefits) that you can freely add and remove variables in one test without worrying about side effects in any of the other tests. Right now, there's only two tests in this file but ideally more tests will be added over time.

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Aug 30, 2016

Member

LGTM

Member

jasnell commented Aug 30, 2016

LGTM

Trott added a commit to Trott/io.js that referenced this pull request Aug 31, 2016

test: add test for zlib.create*Raw()
Currently, there are no tests that exercise `zlib.createInflateRaw()` or
`zlib.createDeflateRaw()`.

This adds minimal tests that invoke the functions and confirm that they
return `zlib.InflateRaw`/`zlib.DeflateRaw` objects.

PR-URL: nodejs#8306
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Aug 31, 2016

Member

Landed in f6e33ef

Member

Trott commented Aug 31, 2016

Landed in f6e33ef

@Trott Trott closed this Aug 31, 2016

@Fishrock123 Fishrock123 referenced this pull request Sep 6, 2016

Closed

v6.6.0 pre-proposal #8428

Fishrock123 added a commit to Fishrock123/node that referenced this pull request Sep 8, 2016

test: add test for zlib.create*Raw()
Currently, there are no tests that exercise `zlib.createInflateRaw()` or
`zlib.createDeflateRaw()`.

This adds minimal tests that invoke the functions and confirm that they
return `zlib.InflateRaw`/`zlib.DeflateRaw` objects.

PR-URL: nodejs#8306
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

Fishrock123 added a commit that referenced this pull request Sep 9, 2016

test: add test for zlib.create*Raw()
Currently, there are no tests that exercise `zlib.createInflateRaw()` or
`zlib.createDeflateRaw()`.

This adds minimal tests that invoke the functions and confirm that they
return `zlib.InflateRaw`/`zlib.DeflateRaw` objects.

PR-URL: #8306
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Sep 30, 2016

test: add test for zlib.create*Raw()
Currently, there are no tests that exercise `zlib.createInflateRaw()` or
`zlib.createDeflateRaw()`.

This adds minimal tests that invoke the functions and confirm that they
return `zlib.InflateRaw`/`zlib.DeflateRaw` objects.

PR-URL: #8306
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Oct 10, 2016

test: add test for zlib.create*Raw()
Currently, there are no tests that exercise `zlib.createInflateRaw()` or
`zlib.createDeflateRaw()`.

This adds minimal tests that invoke the functions and confirm that they
return `zlib.InflateRaw`/`zlib.DeflateRaw` objects.

PR-URL: #8306
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

rvagg added a commit that referenced this pull request Oct 18, 2016

test: add test for zlib.create*Raw()
Currently, there are no tests that exercise `zlib.createInflateRaw()` or
`zlib.createDeflateRaw()`.

This adds minimal tests that invoke the functions and confirm that they
return `zlib.InflateRaw`/`zlib.DeflateRaw` objects.

PR-URL: #8306
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Oct 26, 2016

test: add test for zlib.create*Raw()
Currently, there are no tests that exercise `zlib.createInflateRaw()` or
`zlib.createDeflateRaw()`.

This adds minimal tests that invoke the functions and confirm that they
return `zlib.InflateRaw`/`zlib.DeflateRaw` objects.

PR-URL: #8306
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

@MylesBorins MylesBorins referenced this pull request Oct 26, 2016

Closed

V4.6.2 proposal #9298

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment