New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add .md to the link #8315

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
6 participants
@Alexis374
Contributor

Alexis374 commented Aug 29, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

fix a wrong link to ../topics/the-event-loop-timers-and-nexttick.md

add .md to the link
fix a wrong link to ../topics/the-event-loop-timers-and-nexttick.md
@addaleax

This comment has been minimized.

Show comment
Hide comment
@addaleax

addaleax Aug 29, 2016

Member

Looks good to me!

Could you amend the commit message so that it starts with doc:, though?

Member

addaleax commented Aug 29, 2016

Looks good to me!

Could you amend the commit message so that it starts with doc:, though?

@Alexis374 Alexis374 changed the title from add .md to the link to doc: add .md to the link Aug 29, 2016

@Fishrock123

This comment has been minimized.

Show comment
Hide comment
@Fishrock123

Fishrock123 Aug 29, 2016

Member

@Alexis374 Looks like you only changed the PR title, not the actual commit.

To amend the commit message, you'll need a local clone of your github fork on node.

Then:

git checkout origin/patch-1
git commit --amend (will bring up an editor such as vim)
git push origin head --force

Member

Fishrock123 commented Aug 29, 2016

@Alexis374 Looks like you only changed the PR title, not the actual commit.

To amend the commit message, you'll need a local clone of your github fork on node.

Then:

git checkout origin/patch-1
git commit --amend (will bring up an editor such as vim)
git push origin head --force

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Aug 29, 2016

Member

LGTM with the commit log fix.

Member

jasnell commented Aug 29, 2016

LGTM with the commit log fix.

Alexis374 and others added some commits Aug 29, 2016

@Alexis374

This comment has been minimized.

Show comment
Hide comment
@Alexis374

Alexis374 Aug 30, 2016

Contributor

@addaleax @Fishrock123 I did as you told, please check whether I did sth wrong.

Contributor

Alexis374 commented Aug 30, 2016

@addaleax @Fishrock123 I did as you told, please check whether I did sth wrong.

@addaleax

This comment has been minimized.

Show comment
Hide comment
@addaleax

addaleax Aug 30, 2016

Member

@Alexis374 it looks like there’s a git merge (or git pull) that got mixed up in your PR… something along the lines of git rebase -i master, then removing all lines except for the doc: fix a wrong link,add '.md' to the link one and then force-pushing again using git push -f would probably work.

(nobody is claiming that git is easy to work with… :/)

Member

addaleax commented Aug 30, 2016

@Alexis374 it looks like there’s a git merge (or git pull) that got mixed up in your PR… something along the lines of git rebase -i master, then removing all lines except for the doc: fix a wrong link,add '.md' to the link one and then force-pushing again using git push -f would probably work.

(nobody is claiming that git is easy to work with… :/)

addaleax added a commit that referenced this pull request Sep 2, 2016

doc: fix a wrong link,add '.md' to the link
fix a wrong link to ../topics/the-event-loop-timers-and-nexttick.md

PR-URL: #8315
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@addaleax

This comment has been minimized.

Show comment
Hide comment
@addaleax

addaleax Sep 2, 2016

Member

I’ve landed 297d4e4 in 5930d59, thanks for the contribution!

Member

addaleax commented Sep 2, 2016

I’ve landed 297d4e4 in 5930d59, thanks for the contribution!

@addaleax addaleax closed this Sep 2, 2016

@Fishrock123 Fishrock123 referenced this pull request Sep 6, 2016

Closed

v6.6.0 pre-proposal #8428

Fishrock123 added a commit to Fishrock123/node that referenced this pull request Sep 8, 2016

doc: fix a wrong link,add '.md' to the link
fix a wrong link to ../topics/the-event-loop-timers-and-nexttick.md

PR-URL: nodejs#8315
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

Fishrock123 added a commit that referenced this pull request Sep 9, 2016

doc: fix a wrong link,add '.md' to the link
fix a wrong link to ../topics/the-event-loop-timers-and-nexttick.md

PR-URL: #8315
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment