New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix typo in documentation #8326

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
8 participants
@hubertmine
Contributor

hubertmine commented Aug 29, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change
@hubertmine

This comment has been minimized.

Show comment
Hide comment
@hubertmine

hubertmine Aug 29, 2016

Contributor

Fix documentation

Contributor

hubertmine commented Aug 29, 2016

Fix documentation

@addaleax

This comment has been minimized.

Show comment
Hide comment
@addaleax

addaleax Aug 29, 2016

Member

Looks good to me, thank you for the PR! Could you update the commit message so that it starts with doc: and is all-lowercase, though?

Member

addaleax commented Aug 29, 2016

Looks good to me, thank you for the PR! Could you update the commit message so that it starts with doc: and is all-lowercase, though?

@mscdex

This comment has been minimized.

Show comment
Hide comment
@mscdex

mscdex Aug 29, 2016

Contributor

LGTM

Contributor

mscdex commented Aug 29, 2016

LGTM

@hubertmine hubertmine changed the title from Fix typo in documentation to doc: fix typo in documentation Aug 29, 2016

@mcollina

This comment has been minimized.

Show comment
Hide comment
@mcollina

mcollina Aug 29, 2016

Member

LGTM

Member

mcollina commented Aug 29, 2016

LGTM

@cjihrig

This comment has been minimized.

Show comment
Hide comment
@cjihrig

cjihrig Aug 29, 2016

Contributor

LGTM

Contributor

cjihrig commented Aug 29, 2016

LGTM

@lpinca

This comment has been minimized.

Show comment
Hide comment
@lpinca

lpinca Aug 30, 2016

Member

LGTM

Member

lpinca commented Aug 30, 2016

LGTM

lpinca added a commit to lpinca/node that referenced this pull request Sep 1, 2016

doc: fix typo in stream doc
PR-URL: nodejs#8326
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@lpinca

This comment has been minimized.

Show comment
Hide comment
@lpinca

lpinca Sep 1, 2016

Member

Landed in f7dd3bc

Member

lpinca commented Sep 1, 2016

Landed in f7dd3bc

@lpinca lpinca closed this Sep 1, 2016

@Fishrock123 Fishrock123 referenced this pull request Sep 6, 2016

Closed

v6.6.0 pre-proposal #8428

Fishrock123 added a commit to Fishrock123/node that referenced this pull request Sep 8, 2016

doc: fix typo in stream doc
PR-URL: nodejs#8326
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Fishrock123 added a commit that referenced this pull request Sep 9, 2016

doc: fix typo in stream doc
PR-URL: #8326
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment