New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: test non-buffer/string with zlib #8350

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@Trott
Member

Trott commented Aug 31, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test zlib

Description of change

Check the error condition testing for passing something other than a
string or buffer. Currently, there are no tests for this error condition.

@Trott Trott added zlib test labels Aug 31, 2016

test: test non-buffer/string with zlib
Check the error condition testing for passing something other than a
string or buffer. Currently, there are no tests for this.
@addaleax

This comment has been minimized.

Show comment
Hide comment
Member

addaleax commented Aug 31, 2016

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Aug 31, 2016

Member

LGTM

Member

jasnell commented Aug 31, 2016

LGTM

@ChALkeR

This comment has been minimized.

Show comment
Hide comment
@ChALkeR

ChALkeR Aug 31, 2016

Member

Perhaps this needs more tests for passing various types of data, e.g. a number?

Member

ChALkeR commented Aug 31, 2016

Perhaps this needs more tests for passing various types of data, e.g. a number?

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Aug 31, 2016

Member

Couldn't hurt to expand the tests a bit more

Member

jasnell commented Aug 31, 2016

Couldn't hurt to expand the tests a bit more

@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott
Member

Trott commented Sep 2, 2016

Added a few more types. CI again: https://ci.nodejs.org/job/node-test-pull-request/3925/

@ChALkeR

This comment has been minimized.

Show comment
Hide comment
@ChALkeR

ChALkeR Sep 2, 2016

Member

arm-fanned failure looks unrelated.

LGTM.

Member

ChALkeR commented Sep 2, 2016

arm-fanned failure looks unrelated.

LGTM.

Trott added a commit to Trott/io.js that referenced this pull request Sep 2, 2016

test: test non-buffer/string with zlib
Check the error condition testing for passing something other than a
string or buffer. Currently, there are no tests for this.

PR-URL: nodejs#8350
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed By: James M Snell <jasnell@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Sep 2, 2016

Member

Landed in 9826a79

Member

Trott commented Sep 2, 2016

Landed in 9826a79

@Trott Trott closed this Sep 2, 2016

@Fishrock123 Fishrock123 referenced this pull request Sep 6, 2016

Closed

v6.6.0 pre-proposal #8428

Fishrock123 added a commit to Fishrock123/node that referenced this pull request Sep 8, 2016

test: test non-buffer/string with zlib
Check the error condition testing for passing something other than a
string or buffer. Currently, there are no tests for this.

PR-URL: nodejs#8350
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed By: James M Snell <jasnell@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>

Fishrock123 added a commit that referenced this pull request Sep 9, 2016

test: test non-buffer/string with zlib
Check the error condition testing for passing something other than a
string or buffer. Currently, there are no tests for this.

PR-URL: #8350
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed By: James M Snell <jasnell@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>

MylesBorins added a commit that referenced this pull request Sep 30, 2016

test: test non-buffer/string with zlib
Check the error condition testing for passing something other than a
string or buffer. Currently, there are no tests for this.

PR-URL: #8350
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed By: James M Snell <jasnell@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>

MylesBorins added a commit that referenced this pull request Oct 10, 2016

test: test non-buffer/string with zlib
Check the error condition testing for passing something other than a
string or buffer. Currently, there are no tests for this.

PR-URL: #8350
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed By: James M Snell <jasnell@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>

rvagg added a commit that referenced this pull request Oct 18, 2016

test: test non-buffer/string with zlib
Check the error condition testing for passing something other than a
string or buffer. Currently, there are no tests for this.

PR-URL: #8350
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed By: James M Snell <jasnell@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>

MylesBorins added a commit that referenced this pull request Oct 26, 2016

test: test non-buffer/string with zlib
Check the error condition testing for passing something other than a
string or buffer. Currently, there are no tests for this.

PR-URL: #8350
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed By: James M Snell <jasnell@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>

@MylesBorins MylesBorins referenced this pull request Oct 26, 2016

Closed

V4.6.2 proposal #9298

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment