New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add return type of clientRequest.setTimeout #8356

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
7 participants
@MikeRalphson
Contributor

MikeRalphson commented Aug 31, 2016

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Document the return type of clientRequest.setTimeout
#1699 did not update documentation

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Aug 31, 2016

Member

LGTM

Member

jasnell commented Aug 31, 2016

LGTM

@lpinca

This comment has been minimized.

Show comment
Hide comment
@lpinca

lpinca Aug 31, 2016

Member

LGTM

Member

lpinca commented Aug 31, 2016

LGTM

@lpinca

This comment has been minimized.

Show comment
Hide comment
@lpinca

lpinca Aug 31, 2016

Member

@MikeRalphson can you please update the commit message?
It must be 50 chars or less all in lowercase and it should include the subsystem as prefix (doc:).
If it is too boring, don't worry, we will take care of it when landing.

Member

lpinca commented Aug 31, 2016

@MikeRalphson can you please update the commit message?
It must be 50 chars or less all in lowercase and it should include the subsystem as prefix (doc:).
If it is too boring, don't worry, we will take care of it when landing.

@MikeRalphson MikeRalphson changed the title from Document return type of clientRequest.setTimeout to doc: add return type of clientRequest.setTimeout Aug 31, 2016

@MikeRalphson

This comment has been minimized.

Show comment
Hide comment
@MikeRalphson

MikeRalphson Aug 31, 2016

Contributor

@lpinca sorry, hopefully that's better (I assumed all lowercase didn't include refs to actual functions etc, from a browse of recent commits). First line of commit msg is now 48 chars.

Contributor

MikeRalphson commented Aug 31, 2016

@lpinca sorry, hopefully that's better (I assumed all lowercase didn't include refs to actual functions etc, from a browse of recent commits). First line of commit msg is now 48 chars.

@lpinca

This comment has been minimized.

Show comment
Hide comment
@lpinca

lpinca Aug 31, 2016

Member

@MikeRalphson instead of "PR #1699 did not update documentation" I would use the "Refs:" metadata, that is Refs: https://github.com/nodejs/node/pull/1699, thanks!

Member

lpinca commented Aug 31, 2016

@MikeRalphson instead of "PR #1699 did not update documentation" I would use the "Refs:" metadata, that is Refs: https://github.com/nodejs/node/pull/1699, thanks!

@MikeRalphson

This comment has been minimized.

Show comment
Hide comment
@MikeRalphson

MikeRalphson Aug 31, 2016

Contributor

@lpinca commit message updated to use Refs: as above.

Contributor

MikeRalphson commented Aug 31, 2016

@lpinca commit message updated to use Refs: as above.

@cjihrig

This comment has been minimized.

Show comment
Hide comment
@cjihrig

cjihrig Sep 1, 2016

Contributor

LGTM

Contributor

cjihrig commented Sep 1, 2016

LGTM

@evanlucas

This comment has been minimized.

Show comment
Hide comment
@evanlucas

evanlucas Sep 1, 2016

Member

lgtm

Member

evanlucas commented Sep 1, 2016

lgtm

lpinca added a commit to lpinca/node that referenced this pull request Sep 3, 2016

doc: add return type of clientRequest.setTimeout
Refs: nodejs#1699
PR-URL: nodejs#8356
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
@lpinca

This comment has been minimized.

Show comment
Hide comment
@lpinca

lpinca Sep 3, 2016

Member

Landed in 7e8d994

Member

lpinca commented Sep 3, 2016

Landed in 7e8d994

@lpinca lpinca closed this Sep 3, 2016

@Fishrock123 Fishrock123 referenced this pull request Sep 6, 2016

Closed

v6.6.0 pre-proposal #8428

Fishrock123 added a commit to Fishrock123/node that referenced this pull request Sep 8, 2016

doc: add return type of clientRequest.setTimeout
Refs: nodejs#1699
PR-URL: nodejs#8356
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>

Fishrock123 added a commit that referenced this pull request Sep 9, 2016

doc: add return type of clientRequest.setTimeout
Refs: #1699
PR-URL: #8356
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>

MylesBorins added a commit that referenced this pull request Sep 30, 2016

doc: add return type of clientRequest.setTimeout
Refs: #1699
PR-URL: #8356
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>

MylesBorins added a commit that referenced this pull request Oct 10, 2016

doc: add return type of clientRequest.setTimeout
Refs: #1699
PR-URL: #8356
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>

rvagg added a commit that referenced this pull request Oct 18, 2016

doc: add return type of clientRequest.setTimeout
Refs: #1699
PR-URL: #8356
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>

MylesBorins added a commit that referenced this pull request Oct 26, 2016

doc: add return type of clientRequest.setTimeout
Refs: #1699
PR-URL: #8356
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>

@MylesBorins MylesBorins referenced this pull request Oct 26, 2016

Closed

V4.6.2 proposal #9298

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment