New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: adding danbev to collaborators #8359

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
7 participants
@danbev
Member

danbev commented Aug 31, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

adding danbev to collaborators

@danbev

This comment has been minimized.

Show comment
Hide comment
@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Aug 31, 2016

Member

LGTM

Member

Trott commented Aug 31, 2016

LGTM

@santigimeno

This comment has been minimized.

Show comment
Hide comment
@santigimeno
Member

santigimeno commented Aug 31, 2016

LGTM

@Fishrock123

This comment has been minimized.

Show comment
Hide comment
@Fishrock123
Member

Fishrock123 commented Aug 31, 2016

LGTM

@danbev

This comment has been minimized.

Show comment
Hide comment
@danbev

danbev Aug 31, 2016

Member

Landed in 56414b5

Member

danbev commented Aug 31, 2016

Landed in 56414b5

@danbev danbev closed this Aug 31, 2016

danbev added a commit that referenced this pull request Aug 31, 2016

doc: adding danbev to collaborators
PR-URL: #8359
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Jeremiah Senkpiel <Fishrock123@rocketmail.com>
@jbergstroem

This comment has been minimized.

Show comment
Hide comment
@jbergstroem

jbergstroem Aug 31, 2016

Member

🚂🚋 LGTM - welcome aboard the commit train ! 🚋🚋

Member

jbergstroem commented Aug 31, 2016

🚂🚋 LGTM - welcome aboard the commit train ! 🚋🚋

@danbev

This comment has been minimized.

Show comment
Hide comment
@danbev

danbev Aug 31, 2016

Member

@jbergstroem Thanks :)

Member

danbev commented Aug 31, 2016

@jbergstroem Thanks :)

@Fishrock123 Fishrock123 referenced this pull request Sep 6, 2016

Closed

v6.6.0 pre-proposal #8428

@danbev danbev deleted the danbev:adding-danbev-to-collaborators branch Sep 7, 2016

Fishrock123 added a commit to Fishrock123/node that referenced this pull request Sep 8, 2016

doc: adding danbev to collaborators
PR-URL: nodejs#8359
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Jeremiah Senkpiel <Fishrock123@rocketmail.com>

Fishrock123 added a commit that referenced this pull request Sep 9, 2016

doc: adding danbev to collaborators
PR-URL: #8359
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Jeremiah Senkpiel <Fishrock123@rocketmail.com>

MylesBorins added a commit that referenced this pull request Sep 30, 2016

doc: adding danbev to collaborators
PR-URL: #8359
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Jeremiah Senkpiel <Fishrock123@rocketmail.com>

MylesBorins added a commit that referenced this pull request Oct 10, 2016

doc: adding danbev to collaborators
PR-URL: #8359
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Jeremiah Senkpiel <Fishrock123@rocketmail.com>

rvagg added a commit that referenced this pull request Oct 18, 2016

doc: adding danbev to collaborators
PR-URL: #8359
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Jeremiah Senkpiel <Fishrock123@rocketmail.com>

MylesBorins added a commit that referenced this pull request Oct 26, 2016

doc: adding danbev to collaborators
PR-URL: #8359
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Jeremiah Senkpiel <Fishrock123@rocketmail.com>

@MylesBorins MylesBorins referenced this pull request Oct 26, 2016

Closed

V4.6.2 proposal #9298

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment