New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix broken link in dgram doc #8365

Merged
merged 1 commit into from Sep 2, 2016

Conversation

Projects
None yet
6 participants
@mscdex
Contributor

mscdex commented Sep 1, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
  • doc
Description of change

Fixes a broken link in dgram doc

cluster is referenced in dgram.bind() but is missing in the list of references at the bottom of the doc markdown.

@lpinca

This comment has been minimized.

Show comment
Hide comment
@lpinca

lpinca Sep 1, 2016

Member

How about also adding [] to the markdown link on line 182? This will make it consistent with the others.

Member

lpinca commented Sep 1, 2016

How about also adding [] to the markdown link on line 182? This will make it consistent with the others.

@mscdex

This comment has been minimized.

Show comment
Hide comment
@mscdex

mscdex Sep 1, 2016

Contributor

@lpinca I actually prefer leaving off extra trailing [] for links like that. At some point when I get a chance to resume my doc improvement PRs, I will eventually get to dgram.md at which point I will propose dropping the [] everywhere. With that in mind, I don't see a point in making the change now.

Contributor

mscdex commented Sep 1, 2016

@lpinca I actually prefer leaving off extra trailing [] for links like that. At some point when I get a chance to resume my doc improvement PRs, I will eventually get to dgram.md at which point I will propose dropping the [] everywhere. With that in mind, I don't see a point in making the change now.

@lpinca

This comment has been minimized.

Show comment
Hide comment
@lpinca

lpinca Sep 1, 2016

Member

Ok. LGTM

Member

lpinca commented Sep 1, 2016

Ok. LGTM

@cjihrig

This comment has been minimized.

Show comment
Hide comment
@cjihrig

cjihrig Sep 1, 2016

Contributor

LGTM

Contributor

cjihrig commented Sep 1, 2016

LGTM

@evanlucas

This comment has been minimized.

Show comment
Hide comment
@evanlucas

evanlucas Sep 1, 2016

Member

lgtm

Member

evanlucas commented Sep 1, 2016

lgtm

@thefourtheye

This comment has been minimized.

Show comment
Hide comment
@thefourtheye

thefourtheye Sep 1, 2016

Contributor

LGTM

Contributor

thefourtheye commented Sep 1, 2016

LGTM

doc: fix broken link in dgram doc
PR-URL: #8365
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>

@mscdex mscdex merged commit 8361c26 into nodejs:master Sep 2, 2016

@mscdex mscdex deleted the mscdex:doc-dgram-fix-typo branch Sep 2, 2016

@Fishrock123 Fishrock123 referenced this pull request Sep 6, 2016

Closed

v6.6.0 pre-proposal #8428

Fishrock123 added a commit to Fishrock123/node that referenced this pull request Sep 8, 2016

doc: fix broken link in dgram doc
PR-URL: nodejs#8365
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>

Fishrock123 added a commit that referenced this pull request Sep 9, 2016

doc: fix broken link in dgram doc
PR-URL: #8365
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>

MylesBorins added a commit that referenced this pull request Oct 11, 2016

doc: fix broken link in dgram doc
PR-URL: #8365
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>

rvagg added a commit that referenced this pull request Oct 18, 2016

doc: fix broken link in dgram doc
PR-URL: #8365
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>

MylesBorins added a commit that referenced this pull request Oct 26, 2016

doc: fix broken link in dgram doc
PR-URL: #8365
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>

@MylesBorins MylesBorins referenced this pull request Oct 26, 2016

Closed

V4.6.2 proposal #9298

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment