New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix typos #8370

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
9 participants
@MikeRalphson
Contributor

MikeRalphson commented Sep 1, 2016

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Fix typos / spelling errors in doc/api and doc/topics

@addaleax

This comment has been minimized.

Show comment
Hide comment
@addaleax

addaleax Sep 1, 2016

Member

Looks good to me!

Member

addaleax commented Sep 1, 2016

Looks good to me!

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Sep 1, 2016

Member

LGTM

Member

jasnell commented Sep 1, 2016

LGTM

@cjihrig

This comment has been minimized.

Show comment
Hide comment
@cjihrig

cjihrig Sep 1, 2016

Contributor

LGTM

Contributor

cjihrig commented Sep 1, 2016

LGTM

@princejwesley

This comment has been minimized.

Show comment
Hide comment
@princejwesley

princejwesley Sep 1, 2016

Contributor

LGTM

Contributor

princejwesley commented Sep 1, 2016

LGTM

@@ -69,7 +69,7 @@ actually uses - are those above._
* **timers**: this phase executes callbacks scheduled by `setTimeout()`
and `setInterval()`.
* **I/O callbacks**: most types of callback except timers, `setImmedate()`, close
* **I/O callbacks**: most types of callback except timers, `setImmediate()`, close

This comment has been minimized.

@thefourtheye

thefourtheye Sep 1, 2016

Contributor

Does this sentence look complete? I am not able to understand this.

@thefourtheye

thefourtheye Sep 1, 2016

Contributor

Does this sentence look complete? I am not able to understand this.

This comment has been minimized.

@lpinca

lpinca Sep 1, 2016

Member

I didn't read the context but as is I also can't understand it.

@lpinca

lpinca Sep 1, 2016

Member

I didn't read the context but as is I also can't understand it.

This comment has been minimized.

@addaleax

addaleax Sep 1, 2016

Member

I think this is supposed to read as: all callbacks, but not the ones listed above under timers, the setImmediate() ones, and those listed under close callbacks which are run later…? But ack, it isn’t very clear…

@addaleax

addaleax Sep 1, 2016

Member

I think this is supposed to read as: all callbacks, but not the ones listed above under timers, the setImmediate() ones, and those listed under close callbacks which are run later…? But ack, it isn’t very clear…

This comment has been minimized.

@lpinca

lpinca Sep 1, 2016

Member

I agree, reading the full list one can infer something like this:

"executes almost all callbacks with the exception of close callbacks, the ones scheduled by timers and setImmediate()"

It is a long sentence but I think it's better to be explicit.

@lpinca

lpinca Sep 1, 2016

Member

I agree, reading the full list one can infer something like this:

"executes almost all callbacks with the exception of close callbacks, the ones scheduled by timers and setImmediate()"

It is a long sentence but I think it's better to be explicit.

@thefourtheye

This comment has been minimized.

Show comment
Hide comment
@thefourtheye

thefourtheye Sep 1, 2016

Contributor

Changes look fine, LGTM.

Contributor

thefourtheye commented Sep 1, 2016

Changes look fine, LGTM.

@lpinca

This comment has been minimized.

Show comment
Hide comment
@lpinca

lpinca Sep 1, 2016

Member

LGTM

Member

lpinca commented Sep 1, 2016

LGTM

addaleax added a commit that referenced this pull request Sep 2, 2016

doc: fix typos
PR-URL: #8370
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@addaleax

This comment has been minimized.

Show comment
Hide comment
@addaleax

addaleax Sep 2, 2016

Member

Landed in 3905f48, thanks for the pull request!

@lpinca Do you want to go ahead and submit your suggestion in a separate PR?

Member

addaleax commented Sep 2, 2016

Landed in 3905f48, thanks for the pull request!

@lpinca Do you want to go ahead and submit your suggestion in a separate PR?

@addaleax addaleax closed this Sep 2, 2016

@lpinca

This comment has been minimized.

Show comment
Hide comment
@lpinca

lpinca Sep 3, 2016

Member

@addaleax yes, will do.

Member

lpinca commented Sep 3, 2016

@addaleax yes, will do.

@lpinca lpinca referenced this pull request Sep 3, 2016

Closed

doc: clarify sentence in event loop doc #8400

2 of 2 tasks complete

lpinca added a commit to lpinca/node that referenced this pull request Sep 6, 2016

@Fishrock123 Fishrock123 referenced this pull request Sep 6, 2016

Closed

v6.6.0 pre-proposal #8428

Fishrock123 added a commit to Fishrock123/node that referenced this pull request Sep 8, 2016

doc: fix typos
PR-URL: nodejs#8370
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Fishrock123 added a commit that referenced this pull request Sep 9, 2016

doc: fix typos
PR-URL: #8370
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

jasnell added a commit that referenced this pull request Sep 9, 2016

doc: clarify sentence in event loop doc
Refs: #8370 (diff)
PR-URL: #8400
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>

Fishrock123 added a commit that referenced this pull request Sep 14, 2016

doc: clarify sentence in event loop doc
Refs: #8370 (diff)
PR-URL: #8400
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment