New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: mark pseudo-tty/no_dropped_stdio as flaky #8385

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
7 participants
@mhdawson
Member

mhdawson commented Sep 2, 2016

  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

pseudo-tty

Description of change

We've determined there is a test issue related to python as
opposed to node, mark as flaky until we an resolve

test: mark pseudo-tty/no_dropped_stdio as flaky
We've determined there is a test issue related to python as
opposed to node, mark as flaky until we an resolve
@cjihrig

This comment has been minimized.

Show comment
Hide comment
@cjihrig

cjihrig Sep 2, 2016

Contributor

LGTM

Contributor

cjihrig commented Sep 2, 2016

LGTM

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Sep 2, 2016

Member

LGTM

Member

jasnell commented Sep 2, 2016

LGTM

@mscdex mscdex added the process label Sep 2, 2016

@mhdawson mhdawson self-assigned this Sep 2, 2016

@Fishrock123

This comment has been minimized.

Show comment
Hide comment
@Fishrock123

Fishrock123 Sep 2, 2016

Member

LGTM

Member

Fishrock123 commented Sep 2, 2016

LGTM

@mhdawson

This comment has been minimized.

Show comment
Hide comment
@mhdawson

mhdawson Sep 6, 2016

Member

Landed as 1ffdee7

Member

mhdawson commented Sep 6, 2016

Landed as 1ffdee7

@mhdawson mhdawson closed this Sep 6, 2016

mhdawson added a commit that referenced this pull request Sep 6, 2016

test: mark pseudo-tty/no_dropped_stdio as flaky
We've determined there is a test issue related to python as
opposed to node, mark as flaky until we can resolve

PR-URL: #8385
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

@Fishrock123 Fishrock123 referenced this pull request Sep 6, 2016

Closed

v6.6.0 pre-proposal #8428

Fishrock123 added a commit to Fishrock123/node that referenced this pull request Sep 8, 2016

test: mark pseudo-tty/no_dropped_stdio as flaky
We've determined there is a test issue related to python as
opposed to node, mark as flaky until we can resolve

PR-URL: nodejs#8385
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

Fishrock123 added a commit that referenced this pull request Sep 9, 2016

test: mark pseudo-tty/no_dropped_stdio as flaky
We've determined there is a test issue related to python as
opposed to node, mark as flaky until we can resolve

PR-URL: #8385
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

MylesBorins added a commit that referenced this pull request Sep 30, 2016

test: mark pseudo-tty/no_dropped_stdio as flaky
We've determined there is a test issue related to python as
opposed to node, mark as flaky until we can resolve

PR-URL: #8385
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

MylesBorins added a commit that referenced this pull request Oct 10, 2016

test: mark pseudo-tty/no_dropped_stdio as flaky
We've determined there is a test issue related to python as
opposed to node, mark as flaky until we can resolve

PR-URL: #8385
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

rvagg added a commit that referenced this pull request Oct 18, 2016

test: mark pseudo-tty/no_dropped_stdio as flaky
We've determined there is a test issue related to python as
opposed to node, mark as flaky until we can resolve

PR-URL: #8385
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

MylesBorins added a commit that referenced this pull request Oct 26, 2016

test: mark pseudo-tty/no_dropped_stdio as flaky
We've determined there is a test issue related to python as
opposed to node, mark as flaky until we can resolve

PR-URL: #8385
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

@MylesBorins MylesBorins referenced this pull request Oct 26, 2016

Closed

V4.6.2 proposal #9298

@mhdawson mhdawson deleted the mhdawson:pseudo-tty branch Mar 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment