New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update BUILDING.md #8398

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
6 participants
@Trott
Member

Trott commented Sep 3, 2016

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change
  • General copy-editing
  • Move [sudo] make install step from general Unix build to own step
  • Remove make test-addons as that is now covered by make test
  • Standardize on /path/to/foo as used elsewhere in the doc
  • Change node -e to ./node -e to avoid using different node binary
doc: update BUILDING.md
* General copy-editing

* Move `[sudo] make install` step from general Unix build to own step

* Remove `make test-addons` as that is now covered by `make test`

* Standardize on `/path/to/foo` as used elsewhere in the doc

* Change `node -e` to `./node -e` to avoid using different node binary

@Trott Trott added the doc label Sep 3, 2016

@mscdex mscdex added the build label Sep 3, 2016

@lpinca

This comment has been minimized.

Show comment
Hide comment
@lpinca

lpinca Sep 3, 2016

Member

LGTM

Member

lpinca commented Sep 3, 2016

LGTM

@Fishrock123

This comment has been minimized.

Show comment
Hide comment
@Fishrock123

Fishrock123 Sep 3, 2016

Member

LGTM

Member

Fishrock123 commented Sep 3, 2016

LGTM

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Sep 4, 2016

Member

LGTM

Member

jasnell commented Sep 4, 2016

LGTM

Trott added a commit to Trott/io.js that referenced this pull request Sep 6, 2016

doc: update BUILDING.md
* General copy-editing

* Move `[sudo] make install` step from general Unix build to own step

* Remove `make test-addons` as that is now covered by `make test`

* Standardize on `/path/to/foo` as used elsewhere in the doc

* Change `node -e` to `./node -e` to avoid using different node binary

PR-URL: nodejs#8398
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Sep 6, 2016

Member

Landed in 30dbc9d

Member

Trott commented Sep 6, 2016

Landed in 30dbc9d

@Trott Trott closed this Sep 6, 2016

Fishrock123 added a commit that referenced this pull request Sep 14, 2016

doc: update BUILDING.md
* General copy-editing

* Move `[sudo] make install` step from general Unix build to own step

* Remove `make test-addons` as that is now covered by `make test`

* Standardize on `/path/to/foo` as used elsewhere in the doc

* Change `node -e` to `./node -e` to avoid using different node binary

PR-URL: #8398
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment