New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: clarify sentence in event loop doc #8400

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
6 participants
@lpinca
Member

lpinca commented Sep 3, 2016

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change
  • Make a sentence in the event loop doc easier to understand.
  • Fix a couple of nits (trailing spaces and missing periods).

Ref: #8370 (diff)

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Sep 4, 2016

Member

LGTM

Member

jasnell commented Sep 4, 2016

LGTM

1 similar comment
@cjihrig

This comment has been minimized.

Show comment
Hide comment
@cjihrig

cjihrig Sep 5, 2016

Contributor

LGTM

Contributor

cjihrig commented Sep 5, 2016

LGTM

@fhinkel

View changes

Show outdated Hide outdated doc/topics/the-event-loop-timers-and-nexttick.md Outdated
@fhinkel

This comment has been minimized.

Show comment
Hide comment
@fhinkel

fhinkel Sep 6, 2016

Member

LGTM with tiny, tiny comment.

Member

fhinkel commented Sep 6, 2016

LGTM with tiny, tiny comment.

jasnell added a commit that referenced this pull request Sep 9, 2016

doc: clarify sentence in event loop doc
Refs: #8370 (diff)
PR-URL: #8400
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Sep 9, 2016

Member

Landed in 88ed3d2

Member

jasnell commented Sep 9, 2016

Landed in 88ed3d2

@jasnell jasnell closed this Sep 9, 2016

@lpinca lpinca deleted the lpinca:clarify/sentence branch Sep 9, 2016

Fishrock123 added a commit that referenced this pull request Sep 14, 2016

doc: clarify sentence in event loop doc
Refs: #8370 (diff)
PR-URL: #8400
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment