New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: moving f function call comment #8405

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
7 participants
@danbev
Member

danbev commented Sep 4, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src

Description of change

The comment about calling the f function seems to have drifted
a little. Moving it to be closer to the actual call.

src: moving f function call comment
The comment about calling the f function seems to have drifted
a little. Moving it to be closer to the actual call.
@addaleax

This comment has been minimized.

Show comment
Hide comment
@addaleax

addaleax Sep 4, 2016

Member

LGTM

Member

addaleax commented Sep 4, 2016

LGTM

@danbev

This comment has been minimized.

Show comment
Hide comment
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Sep 4, 2016

Member

LGTM

Member

jasnell commented Sep 4, 2016

LGTM

@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Sep 5, 2016

Member

The Raspberry Pi failure is unrelated, of course, and due to some ongoing difficulties that have hopefully been resolved now, but in any event, don't need to hold this up IMO.

Member

Trott commented Sep 5, 2016

The Raspberry Pi failure is unrelated, of course, and due to some ongoing difficulties that have hopefully been resolved now, but in any event, don't need to hold this up IMO.

@danbev

This comment has been minimized.

Show comment
Hide comment
@danbev

danbev Sep 5, 2016

Member

Landed in a01e8bc

Member

danbev commented Sep 5, 2016

Landed in a01e8bc

@danbev danbev closed this Sep 5, 2016

danbev added a commit that referenced this pull request Sep 5, 2016

src: moving f function call comment
The comment about calling the f function seems to have drifted
a little. Moving it to be closer to the actual call.

PR-URL: #8405
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Fishrock123

This comment has been minimized.

Show comment
Hide comment
@Fishrock123

Fishrock123 Sep 6, 2016

Member

Why was this landed without addressing the comments? I'm 99% certain I posted those here, and not in the landed commit..??

Member

Fishrock123 commented Sep 6, 2016

Why was this landed without addressing the comments? I'm 99% certain I posted those here, and not in the landed commit..??

@danbev

This comment has been minimized.

Show comment
Hide comment
@danbev

danbev Sep 6, 2016

Member

I honestly did not notice the comments until after I had committed the
changes and pushed them. I did not intentionally ignore the comments and I
should have waited longer before merging. I was a little too eager but
will make sure to allow more time for reviews. Sorry about this.

tisdag 6 september 2016 skrev Jeremiah Senkpiel notifications@github.com:

Why was this landed without addressing the comments? I'm 99% certain I
posted those here, and not in the landed commit..??


You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#8405 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAaY3__HpJJhL4SuYUnTpFCkOL9BJvXAks5qnXNlgaJpZM4J0mlA
.

Member

danbev commented Sep 6, 2016

I honestly did not notice the comments until after I had committed the
changes and pushed them. I did not intentionally ignore the comments and I
should have waited longer before merging. I was a little too eager but
will make sure to allow more time for reviews. Sorry about this.

tisdag 6 september 2016 skrev Jeremiah Senkpiel notifications@github.com:

Why was this landed without addressing the comments? I'm 99% certain I
posted those here, and not in the landed commit..??


You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#8405 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAaY3__HpJJhL4SuYUnTpFCkOL9BJvXAks5qnXNlgaJpZM4J0mlA
.

@Fishrock123 Fishrock123 referenced this pull request Sep 6, 2016

Closed

v6.6.0 pre-proposal #8428

@danbev danbev deleted the danbev:moving-f-function-call-comment branch Sep 7, 2016

Fishrock123 added a commit to Fishrock123/node that referenced this pull request Sep 8, 2016

src: moving f function call comment
The comment about calling the f function seems to have drifted
a little. Moving it to be closer to the actual call.

PR-URL: nodejs#8405
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

Fishrock123 added a commit that referenced this pull request Sep 9, 2016

src: moving f function call comment
The comment about calling the f function seems to have drifted
a little. Moving it to be closer to the actual call.

PR-URL: #8405
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment