New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add CI help/support info to onboarding doc #8407

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@Trott
Member

Trott commented Sep 5, 2016

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

@Trott Trott added the doc label Sep 5, 2016

Show outdated Hide outdated doc/onboarding.md
@@ -115,6 +115,10 @@ onboarding session.
* The `CERTIFY_SAFE` box should be checked. By checking it, you are indicating that you have reviewed the code you are about to test and you are confident that it does not contain any malicious code. (We don't want people hijacking our CI hosts to attack other hosts on the internet, for example!)
* The `PR_ID` box should be filled in with the number identifying the pull request containing the code you wish to test. For example, if the URL for the pull request is `https://github.com/nodejs/node/issues/7006`, then put `7006` in the `PR_ID`.
* The remaining elements on the form are typically unchanged with the exception of `POST_STATUS_TO_PR`. Check that if you want a CI status indicator to be automatically inserted into the PR.
* If you need help with something CI-related:
* #node-dev (IRC) to talk to other Collaborators

This comment has been minimized.

@lpinca

lpinca Sep 5, 2016

Member

Nit: use periods at the end of these sentences?

@lpinca

lpinca Sep 5, 2016

Member

Nit: use periods at the end of these sentences?

This comment has been minimized.

@Trott

Trott Sep 5, 2016

Member

Thanks! Added a period and also a verb to make them complete sentences. PTAL

@Trott

Trott Sep 5, 2016

Member

Thanks! Added a period and also a verb to make them complete sentences. PTAL

@lpinca

This comment has been minimized.

Show comment
Hide comment
@lpinca

lpinca Sep 5, 2016

Member

LGTM

Member

lpinca commented Sep 5, 2016

LGTM

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Sep 7, 2016

Member

LGTM

Member

jasnell commented Sep 7, 2016

LGTM

Trott added a commit to Trott/io.js that referenced this pull request Sep 8, 2016

doc: add CI help/support info to onboarding doc
PR-URL: nodejs#8407
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Sep 8, 2016

Member

Landed in 75a2ad1

Member

Trott commented Sep 8, 2016

Landed in 75a2ad1

@Trott Trott closed this Sep 8, 2016

Fishrock123 added a commit that referenced this pull request Sep 14, 2016

doc: add CI help/support info to onboarding doc
PR-URL: #8407
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Sep 30, 2016

doc: add CI help/support info to onboarding doc
PR-URL: #8407
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Oct 10, 2016

doc: add CI help/support info to onboarding doc
PR-URL: #8407
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

rvagg added a commit that referenced this pull request Oct 18, 2016

doc: add CI help/support info to onboarding doc
PR-URL: #8407
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Oct 26, 2016

doc: add CI help/support info to onboarding doc
PR-URL: #8407
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@MylesBorins MylesBorins referenced this pull request Oct 26, 2016

Closed

V4.6.2 proposal #9298

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment