New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: update f function call comment #8416

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
8 participants
@danbev
Member

danbev commented Sep 6, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

src

Description of change

Commit a01e8bc moved a comment to be closer to the place in the code it
was describing. While working on this there was feedback on the comment
itself.

This PR includes the suggestions in the above comments.

src: updating f function call comment
Commit a01e8bc moved a comment to be closer to the place in the code it
was describing. While working on this there was feedback on the comment
itself:
https://github.com/nodejs/node/commit/
a01e8bc#comments

This PR includes the suggestions in the above comments.
@danbev

This comment has been minimized.

Show comment
Hide comment

@mscdex mscdex added the C++ label Sep 6, 2016

@cjihrig

This comment has been minimized.

Show comment
Hide comment
@cjihrig

cjihrig Sep 6, 2016

Contributor

LGTM

Contributor

cjihrig commented Sep 6, 2016

LGTM

@Fishrock123

This comment has been minimized.

Show comment
Hide comment
@Fishrock123

Fishrock123 Sep 6, 2016

Member

LGTM I suppose?

Member

Fishrock123 commented Sep 6, 2016

LGTM I suppose?

@fhinkel

This comment has been minimized.

Show comment
Hide comment
@fhinkel

fhinkel Sep 6, 2016

Member

LGTM.

Member

fhinkel commented Sep 6, 2016

LGTM.

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Sep 7, 2016

Member

LGTM. I'd say this is minor enough that it doesn't need to wait the 48 hours.

Member

jasnell commented Sep 7, 2016

LGTM. I'd say this is minor enough that it doesn't need to wait the 48 hours.

@targos

This comment has been minimized.

Show comment
Hide comment
@targos

targos Sep 7, 2016

Member

Nit: commit title should use the imperative tense

Member

targos commented Sep 7, 2016

Nit: commit title should use the imperative tense

@danbev

This comment has been minimized.

Show comment
Hide comment
@danbev

danbev Sep 7, 2016

Member

@targos Thanks for pointing this out. I'll update the commit title and adhere to this in the future.

Member

danbev commented Sep 7, 2016

@targos Thanks for pointing this out. I'll update the commit title and adhere to this in the future.

@danbev danbev changed the title from src: updating f function call comment to src: update f function call comment Sep 7, 2016

@danbev

This comment has been minimized.

Show comment
Hide comment
@danbev

danbev Sep 7, 2016

Member

Landed in 8afde12

Member

danbev commented Sep 7, 2016

Landed in 8afde12

@danbev danbev closed this Sep 7, 2016

danbev added a commit that referenced this pull request Sep 7, 2016

src: update f function call comment
Commit a01e8bc (src: moving f function call comment, 2016-09-04) moved
a comment to be closer to the place in the code it was describing.
While working on this there was feedback on the comment
itself:
https://github.com/nodejs/node/commit/
a01e8bc#comments

This PR includes the suggestions in the above comments.

PR-URL: #8416
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Franziska Hinkelmann <franzih@chromium.org>
Reviewed-By: James M Snell <jasnell@gmail.com>

Fishrock123 added a commit that referenced this pull request Sep 14, 2016

src: update f function call comment
Commit a01e8bc (src: moving f function call comment, 2016-09-04) moved
a comment to be closer to the place in the code it was describing.
While working on this there was feedback on the comment
itself:
https://github.com/nodejs/node/commit/
a01e8bc#comments

This PR includes the suggestions in the above comments.

PR-URL: #8416
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Franziska Hinkelmann <franzih@chromium.org>
Reviewed-By: James M Snell <jasnell@gmail.com>

@danbev danbev deleted the danbev:updating-f-function-call-comment branch Sep 26, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment