New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: remove unneeded Environment error methods #8427

Merged
merged 1 commit into from Sep 11, 2016

Conversation

Projects
None yet
7 participants
@bnoordhuis
Member

bnoordhuis commented Sep 6, 2016

They seem to have been introduced as "convenience methods" in commit
75adde0 ("src: remove node_isolate from source") for reasons I can
only guess at but they can be removed without much hassle.

@bnoordhuis

This comment has been minimized.

Show comment
Hide comment
@cjihrig

This comment has been minimized.

Show comment
Hide comment
@cjihrig

cjihrig Sep 6, 2016

Contributor

LGTM. CI is yellow.

Contributor

cjihrig commented Sep 6, 2016

LGTM. CI is yellow.

@addaleax

This comment has been minimized.

Show comment
Hide comment
@addaleax

addaleax Sep 6, 2016

Member

LGTM

Member

addaleax commented Sep 6, 2016

LGTM

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Sep 7, 2016

Member

LGTM. Nice cleanup

Member

jasnell commented Sep 7, 2016

LGTM. Nice cleanup

@fhinkel

This comment has been minimized.

Show comment
Hide comment
@fhinkel

fhinkel Sep 7, 2016

Member

LGTM.

Member

fhinkel commented Sep 7, 2016

LGTM.

src: remove unneeded Environment error methods
They seem to have been introduced as "convenience methods" in commit
75adde0 ("src: remove `node_isolate` from source") for reasons I can
only guess at but they can be removed without much hassle.

PR-URL: #8427
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@bnoordhuis bnoordhuis closed this Sep 11, 2016

@bnoordhuis bnoordhuis deleted the bnoordhuis:remove-throwerror-methods branch Sep 11, 2016

@bnoordhuis bnoordhuis merged commit 0e6c336 into nodejs:master Sep 11, 2016

Fishrock123 added a commit that referenced this pull request Sep 14, 2016

src: remove unneeded Environment error methods
They seem to have been introduced as "convenience methods" in commit
75adde0 ("src: remove `node_isolate` from source") for reasons I can
only guess at but they can be removed without much hassle.

PR-URL: #8427
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

 Conflicts:
	src/env.h
@MylesBorins

This comment has been minimized.

Show comment
Hide comment
@MylesBorins

MylesBorins Sep 30, 2016

Member

This does not land cleanly in LTS. Added dont-land label. Please feel free to manually backport

Member

MylesBorins commented Sep 30, 2016

This does not land cleanly in LTS. Added dont-land label. Please feel free to manually backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment