New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win,build: forward release_urlbase to configure #8430

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@joaocgreis
Member

joaocgreis commented Sep 7, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

Windows, Build.

Description of change

The RELEASE_URLBASE environment variable is used in releases as a prefix for links in the process.release object (#2154). The Makefile picks it and forwards it to configure, but vcbuild.bat did not. Hence, in Windows, Node releases have a correct process.release because it uses the default URL, but nightlies, RCs and so on do not, breaking node-gyp. This enables native modules to be built with such versions of Node.

cc @nodejs/platform-windows

win,build: forward release_urlbase to configure
The RELEASE_URLBASE environment variable is used in releases as
a prefix for links in the process.release object. The Makefile picks
it and forwards it to configure, but vcbuild.bat did not. Hence, in
Windows, Node releases have a correct process.release because it uses
the default URL, but nightlies, RCs and so on do not, breaking
node-gyp. This enables native modules to be built with such versions
of Node.
@joaocgreis

This comment has been minimized.

Show comment
Hide comment
@jbergstroem

This comment has been minimized.

Show comment
Hide comment
@jbergstroem

jbergstroem Sep 7, 2016

Member

LGTM

Member

jbergstroem commented Sep 7, 2016

LGTM

@orangemocha

This comment has been minimized.

Show comment
Hide comment
@orangemocha

orangemocha Sep 9, 2016

Member

Nothing in CI tests, but just to be extra safe: https://ci.nodejs.org/job/node-test-commit/4973/

The arm failure is certainly unrelated.

Member

orangemocha commented Sep 9, 2016

Nothing in CI tests, but just to be extra safe: https://ci.nodejs.org/job/node-test-commit/4973/

The arm failure is certainly unrelated.

orangemocha added a commit that referenced this pull request Sep 9, 2016

win,build: forward release_urlbase to configure
The RELEASE_URLBASE environment variable is used in releases as
a prefix for links in the process.release object. The Makefile picks
it and forwards it to configure, but vcbuild.bat did not. Hence, in
Windows, Node releases have a correct process.release because it uses
the default URL, but nightlies, RCs and so on do not, breaking
node-gyp. This enables native modules to be built with such versions
of Node.

PR-URL: #8430
Reviewed-By: jbergstroem - Johan Bergström <bugs@bergstroem.nu>
@orangemocha

This comment has been minimized.

Show comment
Hide comment
@orangemocha

orangemocha Sep 9, 2016

Member

Landed in 137b7cb (@joaocgreis is off today, I am landing this on his behalf so that this can make the v7.x cut on Monday).

Member

orangemocha commented Sep 9, 2016

Landed in 137b7cb (@joaocgreis is off today, I am landing this on his behalf so that this can make the v7.x cut on Monday).

@orangemocha orangemocha closed this Sep 9, 2016

Fishrock123 added a commit that referenced this pull request Sep 14, 2016

win,build: forward release_urlbase to configure
The RELEASE_URLBASE environment variable is used in releases as
a prefix for links in the process.release object. The Makefile picks
it and forwards it to configure, but vcbuild.bat did not. Hence, in
Windows, Node releases have a correct process.release because it uses
the default URL, but nightlies, RCs and so on do not, breaking
node-gyp. This enables native modules to be built with such versions
of Node.

PR-URL: #8430
Reviewed-By: jbergstroem - Johan Bergström <bugs@bergstroem.nu>

joaocgreis added a commit to janeasystems/node that referenced this pull request Sep 14, 2016

win,build: forward release_urlbase to configure
The RELEASE_URLBASE environment variable is used in releases as
a prefix for links in the process.release object. The Makefile picks
it and forwards it to configure, but vcbuild.bat did not. Hence, in
Windows, Node releases have a correct process.release because it uses
the default URL, but nightlies, RCs and so on do not, breaking
node-gyp. This enables native modules to be built with such versions
of Node.

PR-URL: nodejs#8430
Reviewed-By: jbergstroem - Johan Bergström <bugs@bergstroem.nu>
@MylesBorins

This comment has been minimized.

Show comment
Hide comment
@MylesBorins

MylesBorins Sep 30, 2016

Member

@joaocgreis should this be backported?

Member

MylesBorins commented Sep 30, 2016

@joaocgreis should this be backported?

@joaocgreis

This comment has been minimized.

Show comment
Hide comment
@joaocgreis

joaocgreis Oct 3, 2016

Member

@thealphanerd yes, thanks!

Member

joaocgreis commented Oct 3, 2016

@thealphanerd yes, thanks!

MylesBorins added a commit that referenced this pull request Oct 11, 2016

win,build: forward release_urlbase to configure
The RELEASE_URLBASE environment variable is used in releases as
a prefix for links in the process.release object. The Makefile picks
it and forwards it to configure, but vcbuild.bat did not. Hence, in
Windows, Node releases have a correct process.release because it uses
the default URL, but nightlies, RCs and so on do not, breaking
node-gyp. This enables native modules to be built with such versions
of Node.

PR-URL: #8430
Reviewed-By: jbergstroem - Johan Bergström <bugs@bergstroem.nu>

rvagg added a commit that referenced this pull request Oct 18, 2016

win,build: forward release_urlbase to configure
The RELEASE_URLBASE environment variable is used in releases as
a prefix for links in the process.release object. The Makefile picks
it and forwards it to configure, but vcbuild.bat did not. Hence, in
Windows, Node releases have a correct process.release because it uses
the default URL, but nightlies, RCs and so on do not, breaking
node-gyp. This enables native modules to be built with such versions
of Node.

PR-URL: #8430
Reviewed-By: jbergstroem - Johan Bergström <bugs@bergstroem.nu>

MylesBorins added a commit that referenced this pull request Oct 26, 2016

win,build: forward release_urlbase to configure
The RELEASE_URLBASE environment variable is used in releases as
a prefix for links in the process.release object. The Makefile picks
it and forwards it to configure, but vcbuild.bat did not. Hence, in
Windows, Node releases have a correct process.release because it uses
the default URL, but nightlies, RCs and so on do not, breaking
node-gyp. This enables native modules to be built with such versions
of Node.

PR-URL: #8430
Reviewed-By: jbergstroem - Johan Bergström <bugs@bergstroem.nu>

@MylesBorins MylesBorins referenced this pull request Oct 26, 2016

Closed

V4.6.2 proposal #9298

joaocgreis added a commit to joaocgreis/node-chakracore that referenced this pull request Nov 16, 2016

win,build: forward release_urlbase to configure
The RELEASE_URLBASE environment variable is used in releases as
a prefix for links in the process.release object. The Makefile picks
it and forwards it to configure, but vcbuild.bat did not. Hence, in
Windows, Node releases have a correct process.release because it uses
the default URL, but nightlies, RCs and so on do not, breaking
node-gyp. This enables native modules to be built with such versions
of Node.

PR-URL: nodejs/node#8430
Reviewed-By: jbergstroem - Johan Bergström <bugs@bergstroem.nu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment