New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test-debug-protocol-execute #8454

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@Trott
Member

Trott commented Sep 8, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test debugger

Description of change

Add test for Protocol object in _debugger module. This test covers
some edge cases that fill some coverage gaps in our testing (such as the
"Unknown state" error).

test: add test-debug-protocol-execute
Add test for `Protocol` object in `_debugger` module. This test covers
some edge cases that fill some coverage gaps in our testing (such as the
"Unknown state" error).
@Trott

This comment has been minimized.

Show comment
Hide comment
require('../common');
const assert = require('assert');
const debug = require('_debugger');

This comment has been minimized.

@bnoordhuis

bnoordhuis Sep 9, 2016

Member

Missed opportunity to write const { Protocol } = require('_debugger'); :-)

@bnoordhuis

bnoordhuis Sep 9, 2016

Member

Missed opportunity to write const { Protocol } = require('_debugger'); :-)

@bnoordhuis

This comment has been minimized.

Show comment
Hide comment
@bnoordhuis

bnoordhuis Sep 9, 2016

Member

LGTM

Member

bnoordhuis commented Sep 9, 2016

LGTM

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Sep 9, 2016

Member

LGTM

Member

jasnell commented Sep 9, 2016

LGTM

@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Sep 9, 2016

Member

Only CI failures are two known flakies, one with an imminent fix, and one being actively worked on.

Member

Trott commented Sep 9, 2016

Only CI failures are two known flakies, one with an imminent fix, and one being actively worked on.

Trott added a commit to Trott/io.js that referenced this pull request Sep 12, 2016

test: add test-debug-protocol-execute
Add test for `Protocol` object in `_debugger` module. This test covers
some edge cases that fill some coverage gaps in our testing (such as the
"Unknown state" error).

PR-URL: nodejs#8454
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Sep 12, 2016

Member

Landed in 5282f0b

Member

Trott commented Sep 12, 2016

Landed in 5282f0b

@Trott Trott closed this Sep 12, 2016

Fishrock123 added a commit that referenced this pull request Sep 14, 2016

test: add test-debug-protocol-execute
Add test for `Protocol` object in `_debugger` module. This test covers
some edge cases that fill some coverage gaps in our testing (such as the
"Unknown state" error).

PR-URL: #8454
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Sep 30, 2016

test: add test-debug-protocol-execute
Add test for `Protocol` object in `_debugger` module. This test covers
some edge cases that fill some coverage gaps in our testing (such as the
"Unknown state" error).

PR-URL: #8454
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Oct 10, 2016

test: add test-debug-protocol-execute
Add test for `Protocol` object in `_debugger` module. This test covers
some edge cases that fill some coverage gaps in our testing (such as the
"Unknown state" error).

PR-URL: #8454
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>

rvagg added a commit that referenced this pull request Oct 18, 2016

test: add test-debug-protocol-execute
Add test for `Protocol` object in `_debugger` module. This test covers
some edge cases that fill some coverage gaps in our testing (such as the
"Unknown state" error).

PR-URL: #8454
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Oct 26, 2016

test: add test-debug-protocol-execute
Add test for `Protocol` object in `_debugger` module. This test covers
some edge cases that fill some coverage gaps in our testing (such as the
"Unknown state" error).

PR-URL: #8454
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>

@MylesBorins MylesBorins referenced this pull request Oct 26, 2016

Closed

V4.6.2 proposal #9298

@joyeecheung joyeecheung referenced this pull request Feb 15, 2017

Closed

debugger, errors: migrate to use internal/errors.js #11380

3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment