New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix example in repl documentation about context properties #8469

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
6 participants
@fhinkel
Member

fhinkel commented Sep 9, 2016

Checklist
  • make -j4 test (UNIX) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Fix an example in the repl documentation that explains how to set context properties.
We want to define the context property repl.context.m, not repl.m.

@addaleax

This comment has been minimized.

Show comment
Hide comment
@addaleax

addaleax Sep 9, 2016

Member

LGTM, thanks! It would be perfect if you could amend the commit’s subject line so that it’s not longer than 50 characters?

Member

addaleax commented Sep 9, 2016

LGTM, thanks! It would be perfect if you could amend the commit’s subject line so that it’s not longer than 50 characters?

doc: fix example in repl documentation
We want to define the context property r.context.m, not r.m.
@fhinkel

This comment has been minimized.

Show comment
Hide comment
@fhinkel

fhinkel Sep 9, 2016

Member

Forgot about that. Done!

Member

fhinkel commented Sep 9, 2016

Forgot about that. Done!

@cjihrig

This comment has been minimized.

Show comment
Hide comment
@cjihrig

cjihrig Sep 9, 2016

Contributor

LGTM

Contributor

cjihrig commented Sep 9, 2016

LGTM

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Sep 12, 2016

Member

LGTM

Member

jasnell commented Sep 12, 2016

LGTM

jasnell added a commit that referenced this pull request Sep 12, 2016

doc: fix example in repl documentation
Define the context property r.context.m, not r.m.

PR-URL: #8469
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Sep 12, 2016

Member

Landed in 73b0182

Member

jasnell commented Sep 12, 2016

Landed in 73b0182

@jasnell jasnell closed this Sep 12, 2016

Fishrock123 added a commit that referenced this pull request Sep 14, 2016

doc: fix example in repl documentation
Define the context property r.context.m, not r.m.

PR-URL: #8469
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment