New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: skip pseudo-tty/no_dropped_stdio test #8470

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@mhdawson
Member

mhdawson commented Sep 9, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

We had marked pseudo-tty/no_dropped_stdio as flaky but
in some failures it hangs and does not seem to timeout,
and or is reported as an error.

Also add prefix to status file as it was missing.

Also fix name of status file in testcfg.py. It
was pointing to message.status instead of
pseudo-tty.status.

@mhdawson mhdawson removed the test label Sep 9, 2016

test: skip pseudo-tty/no_dropped_stdio test
We had marked it as flaky but in some failures it hangs
and does not seem to timeout, and or is reported as
an error.

Also add prefix to status file as it was missing.

Also fix name of status file in testcfg.py. It
was pointing to message.status instead of
pseudo-tty.status.

@mhdawson mhdawson self-assigned this Sep 9, 2016

@mhdawson

This comment has been minimized.

Show comment
Hide comment

@mhdawson mhdawson added the test label Sep 9, 2016

@mhdawson

This comment has been minimized.

Show comment
Hide comment
@mhdawson

mhdawson Sep 9, 2016

Member

CI run was all green.

Member

mhdawson commented Sep 9, 2016

CI run was all green.

@santigimeno

This comment has been minimized.

Show comment
Hide comment
@santigimeno

santigimeno Sep 9, 2016

Member

LGTM

Member

santigimeno commented Sep 9, 2016

LGTM

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Sep 10, 2016

Member

LGTM

Member

jasnell commented Sep 10, 2016

LGTM

mhdawson added a commit that referenced this pull request Sep 12, 2016

test: skip pseudo-tty/no_dropped_stdio test
We had marked it as flaky but in some failures it hangs
and does not seem to timeout, and or is reported as
an error.

Also add prefix to status file as it was missing.

Also fix name of status file in testcfg.py. It
was pointing to message.status instead of
pseudo-tty.status.

PR-URL: #8470
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
@mhdawson

This comment has been minimized.

Show comment
Hide comment
@mhdawson

mhdawson Sep 12, 2016

Member

Landed as 1ffdbb6

Member

mhdawson commented Sep 12, 2016

Landed as 1ffdbb6

@mhdawson mhdawson closed this Sep 12, 2016

Fishrock123 added a commit that referenced this pull request Sep 14, 2016

test: skip pseudo-tty/no_dropped_stdio test
We had marked it as flaky but in some failures it hangs
and does not seem to timeout, and or is reported as
an error.

Also add prefix to status file as it was missing.

Also fix name of status file in testcfg.py. It
was pointing to message.status instead of
pseudo-tty.status.

PR-URL: #8470
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>

MylesBorins added a commit that referenced this pull request Sep 30, 2016

test: skip pseudo-tty/no_dropped_stdio test
We had marked it as flaky but in some failures it hangs
and does not seem to timeout, and or is reported as
an error.

Also add prefix to status file as it was missing.

Also fix name of status file in testcfg.py. It
was pointing to message.status instead of
pseudo-tty.status.

PR-URL: #8470
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>

@mhdawson mhdawson referenced this pull request Oct 3, 2016

Closed

AIX: hang on 4.x run #8847

MylesBorins added a commit that referenced this pull request Oct 10, 2016

test: skip pseudo-tty/no_dropped_stdio test
We had marked it as flaky but in some failures it hangs
and does not seem to timeout, and or is reported as
an error.

Also add prefix to status file as it was missing.

Also fix name of status file in testcfg.py. It
was pointing to message.status instead of
pseudo-tty.status.

PR-URL: #8470
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>

rvagg added a commit that referenced this pull request Oct 18, 2016

test: skip pseudo-tty/no_dropped_stdio test
We had marked it as flaky but in some failures it hangs
and does not seem to timeout, and or is reported as
an error.

Also add prefix to status file as it was missing.

Also fix name of status file in testcfg.py. It
was pointing to message.status instead of
pseudo-tty.status.

PR-URL: #8470
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>

MylesBorins added a commit that referenced this pull request Oct 26, 2016

test: skip pseudo-tty/no_dropped_stdio test
We had marked it as flaky but in some failures it hangs
and does not seem to timeout, and or is reported as
an error.

Also add prefix to status file as it was missing.

Also fix name of status file in testcfg.py. It
was pointing to message.status instead of
pseudo-tty.status.

PR-URL: #8470
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>

@MylesBorins MylesBorins referenced this pull request Oct 26, 2016

Closed

V4.6.2 proposal #9298

@mhdawson mhdawson deleted the mhdawson:pseudo branch Mar 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment