Update ESLint, replace custom rule with built-in #8478

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
4 participants
@Trott
Member

Trott commented Sep 10, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

tools

Description of change

Three commits:

  • Preparatory commit that fixes some instances where the new keyword is used without parentheses. These are some edge cases that were missed by the previous version of ESLint. Basically, the rule got a bug fix, and now it's finding a tiny bit more stuff in our code.
  • The usual huge honkin' change set that upgrades ESLint.
  • A commit that replaces the custom rule we have that forbids assert.deepEqual() with a built-in rule that does the same (and seems to find a few uses that our custom rule did not, so that's a plus).

Trott added some commits Sep 10, 2016

tools: replace custom ESLint rule with built-in
ESLint 3.5.0 introduces a `no-restricted-properties` rule. Replace our
custom `no-deepEqual` rule with this rule.
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Sep 12, 2016

Member

LGTM if CI is green.

Member

jasnell commented Sep 12, 2016

LGTM if CI is green.

@Trott

This comment has been minimized.

Show comment
Hide comment

Trott added a commit to Trott/io.js that referenced this pull request Sep 13, 2016

tools: fix new-parens violations
PR-URL: nodejs#8478
Reviewed-By: James M Snell <jasnell@gmail.com>

Trott added a commit to Trott/io.js that referenced this pull request Sep 13, 2016

tools: update ESLint to 3.5.0
PR-URL: nodejs#8478
Reviewed-By: James M Snell <jasnell@gmail.com>

Trott added a commit to Trott/io.js that referenced this pull request Sep 13, 2016

tools: replace custom ESLint rule with built-in
ESLint 3.5.0 introduces a `no-restricted-properties` rule. Replace our
custom `no-deepEqual` rule with this rule.

PR-URL: nodejs#8478
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Sep 13, 2016

Member

Landed in a6b1f17, 2da2625, and d4061a6.

Member

Trott commented Sep 13, 2016

Landed in a6b1f17, 2da2625, and d4061a6.

@Trott Trott closed this Sep 13, 2016

Fishrock123 added a commit that referenced this pull request Sep 14, 2016

tools: fix new-parens violations
PR-URL: #8478
Reviewed-By: James M Snell <jasnell@gmail.com>

Fishrock123 added a commit that referenced this pull request Sep 14, 2016

tools: update ESLint to 3.5.0
PR-URL: #8478
Reviewed-By: James M Snell <jasnell@gmail.com>

Fishrock123 added a commit that referenced this pull request Sep 14, 2016

tools: replace custom ESLint rule with built-in
ESLint 3.5.0 introduces a `no-restricted-properties` rule. Replace our
custom `no-deepEqual` rule with this rule.

PR-URL: #8478
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins

This comment has been minimized.

Show comment
Hide comment
@MylesBorins

MylesBorins Sep 30, 2016

Member

@Trott do you want to backport this to lts?

Member

MylesBorins commented Sep 30, 2016

@Trott do you want to backport this to lts?

@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Oct 1, 2016

Member

@Trott do you want to backport this to lts?

@thealphanerd I'm inclined to skip it if it doesn't cause you any problems.

Member

Trott commented Oct 1, 2016

@Trott do you want to backport this to lts?

@thealphanerd I'm inclined to skip it if it doesn't cause you any problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment