Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Changed 'join' to 'joins' in path.md #8527

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
8 participants
@kalmanh
Copy link
Contributor

commented Sep 14, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

Redoing #8522

@cjihrig

This comment has been minimized.

Copy link
Contributor

commented Sep 14, 2016

LGTM. Why did you open a new PR?

@imyller

This comment has been minimized.

Copy link
Member

commented Sep 14, 2016

LGTM

@lpinca

This comment has been minimized.

Copy link
Member

commented Sep 14, 2016

Nit: can you please update your commit message and replace 'Changed' with 'change'? Thanks!

@jasnell
Copy link
Member

left a comment

LGTM

@targos

targos approved these changes Sep 15, 2016

Copy link
Member

left a comment

LGTM

@lpinca

lpinca approved these changes Sep 18, 2016

Copy link
Member

left a comment

LGTM

lpinca added a commit that referenced this pull request Sep 18, 2016

doc: fix typo in path doc
PR-URL: #8527
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@lpinca

This comment has been minimized.

Copy link
Member

commented Sep 18, 2016

Landed in db1087c.

@lpinca lpinca closed this Sep 18, 2016

Fishrock123 added a commit that referenced this pull request Oct 11, 2016

doc: fix typo in path doc
PR-URL: #8527
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.