Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update equal to strictEqual & function to arrow function #8596

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
8 participants
@digitalsadhu
Copy link
Contributor

commented Sep 17, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change
  • update 4 instances of equal to strictEqual
  • 1 instance of function to arrow function syntax

@mscdex mscdex added the fs label Sep 17, 2016

@cjihrig
Copy link
Contributor

left a comment

LGTM

@addaleax
Copy link
Member

left a comment

LGTM with one suggestion

@@ -11,12 +11,12 @@ fs.read(fd,
expected.length,
0,
'utf-8',
common.mustCall(function(err, str, bytesRead) {
common.mustCall((err, str, bytesRead) => {
assert.ok(!err);

This comment has been minimized.

Copy link
@addaleax

addaleax Sep 17, 2016

Member

This could be assert.ifError(err);, which gives slightly more information when anything fails.

@jasnell
Copy link
Member

left a comment

LGTM. +1 to @addaleax's comment regarding using assert.ifError()

@digitalsadhu

This comment has been minimized.

Copy link
Contributor Author

commented Sep 20, 2016

Changed .ok to .ifError as suggested. Ready for re-review.

@jasnell

This comment has been minimized.

Copy link
Member

commented Sep 20, 2016

@Trott Trott force-pushed the nodejs:master branch to c5ce7f4 Sep 21, 2016

@lpinca

lpinca approved these changes Sep 22, 2016

Copy link
Member

left a comment

LGTM

jasnell added a commit that referenced this pull request Sep 22, 2016

test: update test/parallel/test-fs-read.js
* Replace equal with strictEqual
* Update functions to arrow functions

PR-URL: #8596
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@jasnell

This comment has been minimized.

Copy link
Member

commented Sep 22, 2016

Landed in 0718dd9. thank you!

@jasnell jasnell closed this Sep 22, 2016

jasnell added a commit that referenced this pull request Sep 29, 2016

test: update test/parallel/test-fs-read.js
* Replace equal with strictEqual
* Update functions to arrow functions

PR-URL: #8596
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Fishrock123 added a commit that referenced this pull request Oct 11, 2016

test: update test/parallel/test-fs-read.js
* Replace equal with strictEqual
* Update functions to arrow functions

PR-URL: #8596
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.