New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: refactor test-crypto test files #8597

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
10 participants
@griffithtp
Contributor

griffithtp commented Sep 17, 2016

Checklist
  • make lint
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Description of change

Updated ./test/parallel/test-crypto*

  • var to const
  • assert.equal to assert.StrictEqual, same with notEqual
  • wrap callback with common.mustCall()
@cjihrig

LGTM pending CI

@mscdex mscdex added the crypto label Sep 17, 2016

@jasnell

LGTM. when landing the commits will need to be squashed and the commit messages should be fixed up.

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Sep 20, 2016

Member

@griffithtp ... thank you for this. Just to point out, the contributing.md file in the node.js project root directly includes the guidelines for commit message formatting. The person who lands this can clean these commits up but if you'd like to give it a go yourself that would be great!

Member

jasnell commented Sep 20, 2016

@griffithtp ... thank you for this. Just to point out, the contributing.md file in the node.js project root directly includes the guidelines for commit message formatting. The person who lands this can clean these commits up but if you'd like to give it a go yourself that would be great!

@griffithtp

This comment has been minimized.

Show comment
Hide comment
@griffithtp

griffithtp Sep 21, 2016

Contributor

@jasnell apologies for this. Rookie mistake.
If I run git rebase -i HEAD~3 now and push again would this fix it and squash?

Contributor

griffithtp commented Sep 21, 2016

@jasnell apologies for this. Rookie mistake.
If I run git rebase -i HEAD~3 now and push again would this fix it and squash?

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Sep 21, 2016

Member

Yep. Specifically, the steps are git rebase -i HEAD~3, squash, redo the commit message, then force push to your branch. This PR will automatically pick up the changes.

Member

jasnell commented Sep 21, 2016

Yep. Specifically, the steps are git rebase -i HEAD~3, squash, redo the commit message, then force push to your branch. This PR will automatically pick up the changes.

@griffithtp

This comment has been minimized.

Show comment
Hide comment
@griffithtp

griffithtp Sep 21, 2016

Contributor

Cool, thanks James @jasnell !
Is there a list of TODOs for newbie contributors we can follow to just crunch the tasks to do.
Otherwise I can carry on with the same principles from the conference last week?

Contributor

griffithtp commented Sep 21, 2016

Cool, thanks James @jasnell !
Is there a list of TODOs for newbie contributors we can follow to just crunch the tasks to do.
Otherwise I can carry on with the same principles from the conference last week?

@addaleax

This comment has been minimized.

Show comment
Hide comment
@addaleax

addaleax Sep 21, 2016

Member

Is there a list of TODOs for newbie contributors we can follow to just crunch the tasks to do.

Well, there’s https://github.com/nodejs/node/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+contribution%22 if you’re feeling up for one of those?

Otherwise I can carry on with the same principles from the conference last week?

I don’t want to steal your thunder or anything, but… keep in mind that the kind of tasks we were doing was chosen specifically to have some good contributions to get used to the process. You can definitely look through the test files and watch for anything that you would consider a significant improvement!

Also, things that we just always need are more benchmarks + more tests (code coverage on Linux).

Member

addaleax commented Sep 21, 2016

Is there a list of TODOs for newbie contributors we can follow to just crunch the tasks to do.

Well, there’s https://github.com/nodejs/node/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+contribution%22 if you’re feeling up for one of those?

Otherwise I can carry on with the same principles from the conference last week?

I don’t want to steal your thunder or anything, but… keep in mind that the kind of tasks we were doing was chosen specifically to have some good contributions to get used to the process. You can definitely look through the test files and watch for anything that you would consider a significant improvement!

Also, things that we just always need are more benchmarks + more tests (code coverage on Linux).

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Sep 21, 2016

Member

... and doc fixes! we always need doc fixes!

Member

jasnell commented Sep 21, 2016

... and doc fixes! we always need doc fixes!

@jasnell

This comment has been minimized.

Show comment
Hide comment
@addaleax

This comment has been minimized.

Show comment
Hide comment
@addaleax

addaleax Sep 24, 2016

Member

make lint output:

/home/sqrt/src/node/test/parallel/test-crypto-hash.js
  50:14  error  Function argument in column 14, expected in 20  align-function-arguments
  87:16  error  Function argument in column 16, expected in 22  align-function-arguments

/home/sqrt/src/node/test/parallel/test-crypto-hmac.js
   71:18  error  Function argument in column 18, expected in 24  align-function-arguments
  237:18  error  Function argument in column 18, expected in 24  align-function-arguments

✖ 4 problems (4 errors, 0 warnings)
Member

addaleax commented Sep 24, 2016

make lint output:

/home/sqrt/src/node/test/parallel/test-crypto-hash.js
  50:14  error  Function argument in column 14, expected in 20  align-function-arguments
  87:16  error  Function argument in column 16, expected in 22  align-function-arguments

/home/sqrt/src/node/test/parallel/test-crypto-hmac.js
   71:18  error  Function argument in column 18, expected in 24  align-function-arguments
  237:18  error  Function argument in column 18, expected in 24  align-function-arguments

✖ 4 problems (4 errors, 0 warnings)
@lpinca

This comment has been minimized.

Show comment
Hide comment
@lpinca

lpinca Oct 1, 2016

Member

@griffithtp can you take a look at the lint issues?

Member

lpinca commented Oct 1, 2016

@griffithtp can you take a look at the lint issues?

@griffithtp

This comment has been minimized.

Show comment
Hide comment
@griffithtp

griffithtp Oct 28, 2016

Contributor

Apologies for late reply.
Have updated indent and ran make lint as suggested by @addaleax
then make -j2 test after rebase from latest upstream master

Contributor

griffithtp commented Oct 28, 2016

Apologies for late reply.
Have updated indent and ran make lint as suggested by @addaleax
then make -j2 test after rebase from latest upstream master

@jasnell jasnell added the stalled label Mar 1, 2017

@fhinkel

This comment has been minimized.

Show comment
Hide comment
@fhinkel

fhinkel Mar 26, 2017

Member

ping @griffithtp Sorry that this PR didn't get more attention. Do you want to rebase (again, sorry!) and ping me? Then I'll start the CI and we can land this. Thanks, sorry for the extra work.

Member

fhinkel commented Mar 26, 2017

ping @griffithtp Sorry that this PR didn't get more attention. Do you want to rebase (again, sorry!) and ping me? Then I'll start the CI and we can land this. Thanks, sorry for the extra work.

test: invoke callback with common.mustCall()
* invoke callback with `common.mustCall()` in test-crypto-hash
* order module declarations aphabetically per test-writing-guide
@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Aug 13, 2017

Member

I took the liberty of rebasing, resolving conflicts, and pushing to your branch. Hope that's OK! Given the staleness of the PR, I figured it probably wasn't a problem. I also edited the commit message a bit to reflect commit message guidelines and the narrower scope of the PR now that it's been rebased (because some of the changes in this PR were already done elsewhere).

CI: https://ci.nodejs.org/job/node-test-pull-request/9642/

Member

Trott commented Aug 13, 2017

I took the liberty of rebasing, resolving conflicts, and pushing to your branch. Hope that's OK! Given the staleness of the PR, I figured it probably wasn't a problem. I also edited the commit message a bit to reflect commit message guidelines and the narrower scope of the PR now that it's been rebased (because some of the changes in this PR were already done elsewhere).

CI: https://ci.nodejs.org/job/node-test-pull-request/9642/

@Trott

Trott approved these changes Aug 13, 2017

@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Aug 13, 2017

Member

Landed in 1df9340.

Thanks for the contribution! 🎉

Member

Trott commented Aug 13, 2017

Landed in 1df9340.

Thanks for the contribution! 🎉

@Trott Trott closed this Aug 13, 2017

Trott added a commit that referenced this pull request Aug 13, 2017

test: invoke callback with common.mustCall()
* invoke callback with `common.mustCall()` in test-crypto-hash
* order module declarations aphabetically per test-writing-guide

PR-URL: #8597
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

MylesBorins added a commit that referenced this pull request Sep 9, 2017

test: invoke callback with common.mustCall()
* invoke callback with `common.mustCall()` in test-crypto-hash
* order module declarations aphabetically per test-writing-guide

PR-URL: #8597
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

@MylesBorins MylesBorins referenced this pull request Sep 10, 2017

Merged

v8.5.0 proposal #15308

MylesBorins added a commit that referenced this pull request Sep 20, 2017

test: invoke callback with common.mustCall()
* invoke callback with `common.mustCall()` in test-crypto-hash
* order module declarations aphabetically per test-writing-guide

PR-URL: #8597
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

MylesBorins added a commit that referenced this pull request Sep 20, 2017

test: invoke callback with common.mustCall()
* invoke callback with `common.mustCall()` in test-crypto-hash
* order module declarations aphabetically per test-writing-guide

PR-URL: #8597
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

@MylesBorins MylesBorins referenced this pull request Sep 20, 2017

Merged

v6.11.4 proposal #15506

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment