Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update var to const #8599

Conversation

Projects
None yet
7 participants
@matt-in-a-hat
Copy link
Contributor

commented Sep 17, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
Affected core subsystem(s)

test

Description of change

Updated var to const

@cjihrig
Copy link
Contributor

left a comment

LGTM

@mscdex mscdex added the cluster label Sep 17, 2016

@imyller

This comment has been minimized.

Copy link
Member

commented Sep 17, 2016

@matt-in-a-hat Could you include reference to specific test in commit message? Thank you.

@matt-in-a-hat matt-in-a-hat force-pushed the matt-in-a-hat:test-cluster-disconnect-unshared-udp branch to d3a3ba1 Sep 20, 2016

@lpinca

lpinca approved these changes Sep 20, 2016

Copy link
Member

left a comment

LGTM

@imyller

This comment has been minimized.

@imyller imyller self-assigned this Sep 20, 2016

@imyller
Copy link
Member

left a comment

LGTM

@imyller

This comment has been minimized.

Copy link
Member

commented Sep 20, 2016

I'll start landing this.

  • Three LGTMs
  • No objections
  • CI test passed (usual unrelated failures)

imyller added a commit to imyller/node that referenced this pull request Sep 20, 2016

test: update test-cluster-disconnect-unshared-udp
Changed var to const

PR-URL: nodejs#8599
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
@imyller

This comment has been minimized.

Copy link
Member

commented Sep 20, 2016

landed in 57b7e85

Thank you for your contribution, @matt-in-a-hat

@imyller imyller closed this Sep 20, 2016

@imyller imyller removed their assignment Sep 20, 2016

Fishrock123 added a commit that referenced this pull request Oct 11, 2016

test: update test-cluster-disconnect-unshared-udp
Changed var to const

PR-URL: #8599
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.