New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed var to const, added strict equality checks #8762

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
10 participants
@llkats
Contributor

llkats commented Sep 24, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test fs

Description of change

Changed var to const where appropriate. Substituted
assert.strictEqual for assert.equal for better type checks.

@mscdex mscdex added the fs label Sep 24, 2016

@bengl

This comment has been minimized.

Show comment
Hide comment
@addaleax

This looks pretty good so far, thank you! I find this test kind of hard to read, so if you have any ideas for other improvements/explaining comments/whatever, please feel free to add that here!

Show outdated Hide outdated test/parallel/test-fs-read-stream-fd-leak.js
@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Sep 24, 2016

Member

LGTM with @addaleax's comments and if CI has no surprises

Member

Trott commented Sep 24, 2016

LGTM with @addaleax's comments and if CI has no surprises

@MylesBorins

This comment has been minimized.

Show comment
Hide comment
@MylesBorins

MylesBorins Sep 24, 2016

Member

LGTM 🎉🎉🎉
@llkats would you be able to squash the changes?

Member

MylesBorins commented Sep 24, 2016

LGTM 🎉🎉🎉
@llkats would you be able to squash the changes?

test: changed var to const, added strict equal checks
Changed var to const where appropriate. Substituted
assert.strictEqual for assert.equal for better type checks.
@llkats

This comment has been minimized.

Show comment
Hide comment
@llkats

llkats Sep 24, 2016

Contributor

@thealphanerd squasht!

Contributor

llkats commented Sep 24, 2016

@thealphanerd squasht!

@lpinca

lpinca approved these changes Sep 25, 2016

LGTM

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Sep 26, 2016

Member

LGTM

Member

jasnell commented Sep 26, 2016

LGTM

jasnell added a commit that referenced this pull request Sep 26, 2016

test: changed var to const, added strict equal checks
Changed var to const where appropriate. Substituted
assert.strictEqual for assert.equal for better type checks.

PR-URL: #8762
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Sep 26, 2016

Member

Landed in 52b6cfb

Member

jasnell commented Sep 26, 2016

Landed in 52b6cfb

@jasnell jasnell closed this Sep 26, 2016

@llkats llkats deleted the llkats:nodetodo-contrib branch Sep 26, 2016

jasnell added a commit that referenced this pull request Sep 29, 2016

test: changed var to const, added strict equal checks
Changed var to const where appropriate. Substituted
assert.strictEqual for assert.equal for better type checks.

PR-URL: #8762
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Fishrock123 added a commit that referenced this pull request Oct 11, 2016

test: changed var to const, added strict equal checks
Changed var to const where appropriate. Substituted
assert.strictEqual for assert.equal for better type checks.

PR-URL: #8762
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment