Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win,tools: ignore linting for line breaks #8785

Closed

Conversation

Projects
None yet
4 participants
@joaocgreis
Copy link
Member

commented Sep 26, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

Windows, tools.

Description of change

Replaces: #7019

Line breaks on Windows should be CRLF, but Node also supports LF. Hence, do not check line breaks on Windows, when running vcbuild jslint.

Credit to @Trott, this is a direct implementation of his suggestion.

Fixes: #6912

cc @nodejs/platform-windows @bnoordhuis

win,tools: ignore linting for line breaks
Line breaks on Windows should be CRLF, but Node also supports LF.
Hence, do not check line breaks on Windows, when running
vcbuild jslint.

Fixes: #6912
@bzoz

bzoz approved these changes Sep 26, 2016

Copy link
Contributor

left a comment

LGTM

@jasnell
Copy link
Member

left a comment

LGTM

jasnell added a commit that referenced this pull request Oct 7, 2016

win,tools: ignore linting for line breaks
Line breaks on Windows should be CRLF, but Node also supports LF.
Hence, do not check line breaks on Windows, when running
vcbuild jslint.

Fixes: #6912
PR-URL: #8785
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@jasnell

This comment has been minimized.

Copy link
Member

commented Oct 7, 2016

Landed in 75a970b.

@jasnell jasnell closed this Oct 7, 2016

jasnell added a commit that referenced this pull request Oct 10, 2016

win,tools: ignore linting for line breaks
Line breaks on Windows should be CRLF, but Node also supports LF.
Hence, do not check line breaks on Windows, when running
vcbuild jslint.

Fixes: #6912
PR-URL: #8785
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

Fishrock123 added a commit that referenced this pull request Oct 11, 2016

win,tools: ignore linting for line breaks
Line breaks on Windows should be CRLF, but Node also supports LF.
Hence, do not check line breaks on Windows, when running
vcbuild jslint.

Fixes: #6912
PR-URL: #8785
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.