Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
win,msi: mark INSTALLDIR property as secure #8795
Affected core subsystem(s)
Description of change
When installing with
This marks INSTALLDIR as secure, allowing it to be passed to the server MSIExec process during installation.
Tested on Windows 7 with the policy set, with the MSI and INSTALLDIR in two different non-C hard drives (showing that other properties get their values corretly). Also tested upgrade from released Node 6.4 to this on Windows 10.
LGTM - this change sounds reasonable. For those who want a reference http://wixtoolset.org/documentation/manual/v3/xsd/wix/property.html