New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win,msi: mark INSTALLDIR property as secure #8795

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
6 participants
@joaocgreis
Member

joaocgreis commented Sep 26, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

Windows, MSI.

Description of change

When installing with Always install with elevated privileges policy set on Windows, MSIExec will spawn an installation process with elevated privileges, but will only be able to pass secure properties to it. Without this change, INSTALLDIR could not be passed and would revert to the default, effectively ignoring any change in the installation directory made by the user.

This marks INSTALLDIR as secure, allowing it to be passed to the server MSIExec process during installation.

Tested on Windows 7 with the policy set, with the MSI and INSTALLDIR in two different non-C hard drives (showing that other properties get their values corretly). Also tested upgrade from released Node 6.4 to this on Windows 10.

Fixes: #6057

cc @nodejs/platform-windows

win,msi: mark INSTALLDIR property as secure
Allows INSTALLDIR to be passed to the server MSIExec process during
installation.

Fixes: #6057
@joaocgreis

This comment has been minimized.

Show comment
Hide comment
@benjamingr

This comment has been minimized.

Show comment
Hide comment
@benjamingr

benjamingr Sep 26, 2016

Member

LGTM - this change sounds reasonable. For those who want a reference http://wixtoolset.org/documentation/manual/v3/xsd/wix/property.html

Member

benjamingr commented Sep 26, 2016

LGTM - this change sounds reasonable. For those who want a reference http://wixtoolset.org/documentation/manual/v3/xsd/wix/property.html

@jasnell

LGTM

@jasongin

This comment has been minimized.

Show comment
Hide comment
@jasongin

jasongin Sep 27, 2016

Contributor

:shipit:

Contributor

jasongin commented Sep 27, 2016

:shipit:

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Oct 7, 2016

Member

@nodejs/build ... does this LGTY?

Member

jasnell commented Oct 7, 2016

@nodejs/build ... does this LGTY?

@joaocgreis

This comment has been minimized.

Show comment
Hide comment
@joaocgreis

joaocgreis Oct 7, 2016

Member

@jasnell sorry, I left this one too long. I take the reviews above as enough to move forward here, I'll land this early next week if there are no objections (or feel free to if you want to land). Thanks for the ping!

Member

joaocgreis commented Oct 7, 2016

@jasnell sorry, I left this one too long. I take the reviews above as enough to move forward here, I'll land this early next week if there are no objections (or feel free to if you want to land). Thanks for the ping!

@joaocgreis

This comment has been minimized.

Show comment
Hide comment
@joaocgreis

joaocgreis Oct 10, 2016

Member

Landed in 4896f0f

Member

joaocgreis commented Oct 10, 2016

Landed in 4896f0f

@joaocgreis joaocgreis closed this Oct 10, 2016

joaocgreis added a commit that referenced this pull request Oct 10, 2016

win,msi: mark INSTALLDIR property as secure
Allows INSTALLDIR to be passed to the server MSIExec process during
installation.

PR-URL: #8795
Fixes: #6057
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell added a commit that referenced this pull request Oct 10, 2016

win,msi: mark INSTALLDIR property as secure
Allows INSTALLDIR to be passed to the server MSIExec process during
installation.

PR-URL: #8795
Fixes: #6057
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Fishrock123 added a commit that referenced this pull request Oct 11, 2016

win,msi: mark INSTALLDIR property as secure
Allows INSTALLDIR to be passed to the server MSIExec process during
installation.

PR-URL: #8795
Fixes: #6057
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Nov 18, 2016

win,msi: mark INSTALLDIR property as secure
Allows INSTALLDIR to be passed to the server MSIExec process during
installation.

PR-URL: #8795
Fixes: #6057
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@MylesBorins MylesBorins referenced this pull request Nov 22, 2016

Merged

v4.7.0 proposal #9736

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment