Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: add missing length argument to send comment #8816

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
8 participants
@danbev
Copy link
Member

commented Sep 28, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

src

Description of change

The list.length argument is missing from the comment and just adding
this for clarity.

src: add missing length argument to send comment
The list.length argument is missing from the comment and just adding
this for clarity.

@mscdex mscdex added the dgram label Sep 28, 2016

@jasnell
Copy link
Member

left a comment

LGTM

@addaleax
Copy link
Member

left a comment

LGTM

@imyller
Copy link
Member

left a comment

LGTM

jasnell added a commit that referenced this pull request Sep 30, 2016

src: add missing length argument to send comment
The list.length argument is missing from the comment and just adding
this for clarity.

PR-URL: #8816
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
@jasnell

This comment has been minimized.

Copy link
Member

commented Sep 30, 2016

Landed in 6e62b71. Thank you!

@jasnell jasnell closed this Sep 30, 2016

@danbev danbev deleted the danbev:add-list-length branch Oct 2, 2016

jasnell added a commit that referenced this pull request Oct 6, 2016

src: add missing length argument to send comment
The list.length argument is missing from the comment and just adding
this for clarity.

PR-URL: #8816
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>

Fishrock123 added a commit that referenced this pull request Oct 11, 2016

src: add missing length argument to send comment
The list.length argument is missing from the comment and just adding
this for clarity.

PR-URL: #8816
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.