Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: bump V8 patch to 84 #8851

Merged
merged 1 commit into from Oct 4, 2016

Conversation

Projects
None yet
7 participants
@MylesBorins
Copy link
Member

commented Sep 29, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

deps

Description of change

The patch should have been bumped in aafc314 but it was missed.

Ref: aafc314
Ref: #8673

@fhinkel

This comment has been minimized.

Copy link
Member

commented Sep 29, 2016

LGTM

1 similar comment
@targos

This comment has been minimized.

Copy link
Member

commented Sep 29, 2016

LGTM

@addaleax
Copy link
Member

left a comment

LGTM

@jasnell
Copy link
Member

left a comment

LGTM

deps: bump V8 patch to 84
The patch should have been bumped in aafc314 but it was missed.

Ref: aafc314
Ref: #8673

PR-URL: #8851
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

@MylesBorins MylesBorins force-pushed the MylesBorins:bump-V8-patch branch to 9d41e89 Oct 4, 2016

@MylesBorins MylesBorins merged commit 9d41e89 into nodejs:v6.x-staging Oct 4, 2016

@MylesBorins

This comment has been minimized.

Copy link
Member Author

commented Oct 4, 2016

landed in 9d41e89

@MylesBorins MylesBorins deleted the MylesBorins:bump-V8-patch branch Nov 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.