New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module: correct comment text "read-only" to "shallow" #8887

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
7 participants
@bengl
Member

bengl commented Oct 1, 2016

Checklist
  • commit message follows commit guidelines
Affected core subsystem(s)

module

Description of change

The comment here was misleading, implying that the property was being
copied as a read-only, when in fact it's just a shallow copy. This
serves the purpose of providing the array for introspection, but it
isn't read-only.

module: correct comment text "read-only" to "shallow"
The comment here was misleading, implying that the property was being
copied as a read-only, when in fact it's just a shallow copy. This
serves the purpose of providing the array for introspection, but it
isn't read-only.
@mscdex

This comment has been minimized.

Show comment
Hide comment
@mscdex

mscdex Oct 1, 2016

Contributor

LGTM

Contributor

mscdex commented Oct 1, 2016

LGTM

@targos

targos approved these changes Oct 1, 2016

@lpinca

lpinca approved these changes Oct 1, 2016

LGTM

@fhinkel

fhinkel approved these changes Oct 3, 2016

@fhinkel

This comment has been minimized.

Show comment
Hide comment
@fhinkel

fhinkel Oct 3, 2016

Member

Thanks! Landed in 4c619ec.

Member

fhinkel commented Oct 3, 2016

Thanks! Landed in 4c619ec.

@fhinkel fhinkel closed this Oct 3, 2016

fhinkel added a commit that referenced this pull request Oct 3, 2016

module: fix comment from "read-only" to "shallow"
The comment here was misleading, implying that the property was being
copied as a read-only, when in fact it's just a shallow copy. This
serves the purpose of providing the array for introspection, but it
isn't read-only.

PR-URL: #8887
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>

jasnell added a commit that referenced this pull request Oct 6, 2016

module: fix comment from "read-only" to "shallow"
The comment here was misleading, implying that the property was being
copied as a read-only, when in fact it's just a shallow copy. This
serves the purpose of providing the array for introspection, but it
isn't read-only.

PR-URL: #8887
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>

Fishrock123 added a commit that referenced this pull request Oct 11, 2016

module: fix comment from "read-only" to "shallow"
The comment here was misleading, implying that the property was being
copied as a read-only, when in fact it's just a shallow copy. This
serves the purpose of providing the array for introspection, but it
isn't read-only.

PR-URL: #8887
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment