New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: v8 - cherry-pick missing v8 floating patch #8907

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
6 participants
@mhdawson
Member

mhdawson commented Oct 3, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

v8

Description of change

cherry-pick missing v8 floating patch
2d524bc

Fixes: #8750

Original commit message:

deps: limit regress/regress-crbug-514081 v8 test

regress/regress-crbug-514081 allocates a 2G block of memory
and if there are multiple variants running at the
same time this can lead to crashes, OOM kills or
the OS failing to allocate memory. This patch
limits us to running a single variant of the test

Fixes: #6340
PR-URL: #6678
Reviewed-By: Ben Noorhduis info@bnoordhuis.nl
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Fedor Indutny fedor@indutny.com

deps: v8 - cherry-pick missing v8 floating patch
2d524bc

Original commit message:

deps: limit regress/regress-crbug-514081 v8 test

regress/regress-crbug-514081 allocates a 2G block of memory
and if there  are multiple variants running at the
same time this can lead to crashes, OOM kills or
the OS failing to allocate memory.  This patch
limits us to running a single variant of the test

Fixes: #6340
PR-URL: #6678
Reviewed-By: Ben Noorhduis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
@targos

This comment has been minimized.

Member

targos commented Oct 3, 2016

LGTM. Sorry for missing it during the V8 update 😕

@mhdawson mhdawson self-assigned this Oct 3, 2016

@mhdawson mhdawson added the test label Oct 3, 2016

@mhdawson

This comment has been minimized.

Member

mhdawson commented Oct 3, 2016

@mhdawson

This comment has been minimized.

Member

mhdawson commented Oct 3, 2016

@MylesBorins

This comment has been minimized.

Member

MylesBorins commented Oct 3, 2016

can we make a document that lists the V8 branches we are maintaining and
floating patches? this could potentially part or the updating V8 doc

/cc @ofrobots

On Mon, Oct 3, 2016, 11:32 AM Michael Dawson notifications@github.com
wrote:

CI run: https://ci.nodejs.org/job/node-test-pull-request/4369/


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#8907 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAecV28mTpQWXDJuZ--Qq8YvZ3ZZOxu_ks5qwSAmgaJpZM4KMtXU
.

@bnoordhuis

LGTM but can you spell my surname correctly, please? :-)

Also, I'd drop the redundant "v8 -" from the status line.

@mhdawson

This comment has been minimized.

Member

mhdawson commented Oct 3, 2016

CI run looked ok other than Windows failures that were present before/after and not related to this change so I think we are good to go.

@bnoordhuis will address your comments while landing.

@mhdawson

This comment has been minimized.

Member

mhdawson commented Oct 4, 2016

Assume this is non-controversial so will plan to land later today.

mhdawson added a commit that referenced this pull request Oct 5, 2016

deps: cherry-pick missing v8 floating patch
2d524bc

Original commit message:

  deps: limit regress/regress-crbug-514081 v8 test

  regress/regress-crbug-514081 allocates a 2G block of memory
  and if there  are multiple variants running at the
  same time this can lead to crashes, OOM kills or
  the OS failing to allocate memory.  This patch
  limits us to running a single variant of the test

  Fixes: #6340
  PR-URL: #6678
  Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
  Reviewed-By: James M Snell <jasnell@gmail.com>
  Reviewed-By: Fedor Indutny <fedor@indutny.com>

PR-URL: #8907
Fixes: #8750
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@mhdawson

This comment has been minimized.

Member

mhdawson commented Oct 5, 2016

Landed as 4b3e4d5

@mhdawson mhdawson closed this Oct 5, 2016

jasnell added a commit that referenced this pull request Oct 6, 2016

deps: cherry-pick missing v8 floating patch
2d524bc

Original commit message:

  deps: limit regress/regress-crbug-514081 v8 test

  regress/regress-crbug-514081 allocates a 2G block of memory
  and if there  are multiple variants running at the
  same time this can lead to crashes, OOM kills or
  the OS failing to allocate memory.  This patch
  limits us to running a single variant of the test

  Fixes: #6340
  PR-URL: #6678
  Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
  Reviewed-By: James M Snell <jasnell@gmail.com>
  Reviewed-By: Fedor Indutny <fedor@indutny.com>

PR-URL: #8907
Fixes: #8750
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@Fishrock123

This comment has been minimized.

Member

Fishrock123 commented Oct 10, 2016

empty patch on v6

@mhdawson mhdawson deleted the mhdawson:v8stress branch Mar 15, 2017

@gibfahn gibfahn referenced this pull request Jun 15, 2017

Closed

Auditing for 6.11.1 #230

2 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment