Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: bump version to v8.0.0 for master #8956

Closed
wants to merge 1 commit into from

Conversation

@rvagg
Copy link
Member

commented Oct 6, 2016

We have a v7.x branch which owns the v7.x versioning so master needs to move on to v8. One of the primary problems we have right now is nightly builds: https://nodejs.org/download/nightly/ they are still coming off master so the only v7.x builds you see there are from master and not from the new v7.x branch. I'd like to have v8.0.0-pre builds coming out of master and start a new nightly stream off v7.x-staging.

I don't think we're updating NODE_MODULE_VERSION at the same time here, that's going to come when we bump V8 on master right? I've already forgotten how our conversation about that played out, @thealphanerd?

@mscdex

This comment has been minimized.

Copy link
Contributor

commented Oct 6, 2016

V8 was already bumped to 5.4, is it going to be bumped again to 5.5+?

@bnoordhuis

This comment has been minimized.

Copy link
Member

commented Oct 6, 2016

I don't think we're updating NODE_MODULE_VERSION at the same time here, that's going to come when we bump V8 on master right?

Not just V8. Backwards incompatible changes to src/node.h or other public headers or e.g. upgrading to libuv v2 would warrant bumps too.

@MylesBorins

This comment has been minimized.

Copy link
Member

commented Oct 6, 2016

@rvagg I think we left it that the bump would happen when a change landed that required it.

@rvagg

This comment has been minimized.

Copy link
Member Author

commented Oct 12, 2016

OK, no NODE_MODULE_VERSION bump. Could I get an lgtm or two for just the major version bump here so we can start splitting off nightlies for v7 and v8?

@danbev
danbev approved these changes Oct 12, 2016
@danbev

This comment has been minimized.

Copy link
Member

commented Oct 12, 2016

LGTM

@addaleax
Copy link
Member

left a comment

LGTM

@rvagg

This comment has been minimized.

Copy link
Member Author

commented Oct 18, 2016

merged @ 762f64a

rvagg added a commit that referenced this pull request Oct 18, 2016
src: bump version to v8.0.0 for master
PR-URL: #8956
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@rvagg

This comment has been minimized.

Copy link
Member Author

commented Oct 18, 2016

merged @ d317184

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.