New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add cluster inspector debug port test #8958

Merged
merged 1 commit into from Oct 10, 2016

Conversation

Projects
None yet
7 participants
@cjihrig
Contributor

cjihrig commented Oct 6, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

This commit adds a test for the debug port value in cluster workers using the inspector debugger.

Refs: #8201
Refs: #8386
Refs: #8550

@jasnell

jasnell approved these changes Oct 6, 2016

LGTM

@imyller

imyller approved these changes Oct 7, 2016

LGTM

@cjihrig

This comment has been minimized.

Contributor

cjihrig commented Oct 10, 2016

test: add cluster inspector debug port test
This commit adds a test for the debug port value in cluster
workers using the inspector debugger.

Refs: #8201
Refs: #8386
Refs: #8550
PR-URL: #8958
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>

@cjihrig cjihrig force-pushed the cjihrig:test branch to 2aa2f85 Oct 10, 2016

@cjihrig cjihrig merged commit 2aa2f85 into nodejs:master Oct 10, 2016

@cjihrig cjihrig deleted the cjihrig:test branch Oct 10, 2016

jasnell added a commit that referenced this pull request Oct 10, 2016

test: add cluster inspector debug port test
This commit adds a test for the debug port value in cluster
workers using the inspector debugger.

Refs: #8201
Refs: #8386
Refs: #8550
PR-URL: #8958
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
@Fishrock123

This comment has been minimized.

Member

Fishrock123 commented Oct 11, 2016

depends on #8386

@gibfahn gibfahn referenced this pull request Jun 15, 2017

Closed

Auditing for 6.11.1 #230

2 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment