New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: fix typo in #endif comment #8989

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
9 participants
@juan-andres
Contributor

juan-andres commented Oct 9, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change
@addaleax

Looks good, thanks!

@thefourtheye

LGTM

@cjihrig

cjihrig approved these changes Oct 9, 2016

@mscdex

This comment has been minimized.

Show comment
Hide comment
@mscdex

mscdex Oct 9, 2016

Contributor

LGTM

Contributor

mscdex commented Oct 9, 2016

LGTM

@lpinca

lpinca approved these changes Oct 9, 2016

LGTM

@jasnell jasnell self-assigned this Oct 10, 2016

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Oct 10, 2016

Member

this is trivial enough that it shouldn't have to wait the full 48 hours to land. Will get it landed now

Member

jasnell commented Oct 10, 2016

this is trivial enough that it shouldn't have to wait the full 48 hours to land. Will get it landed now

jasnell added a commit that referenced this pull request Oct 10, 2016

src: fix typo in #endif comment
PR-URL: #8989
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Brian White <mscdex@mscdex.net>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Oct 10, 2016

Member

Landed in 13a204e

Member

jasnell commented Oct 10, 2016

Landed in 13a204e

@jasnell jasnell closed this Oct 10, 2016

jasnell added a commit that referenced this pull request Oct 10, 2016

src: fix typo in #endif comment
PR-URL: #8989
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Brian White <mscdex@mscdex.net>

Fishrock123 added a commit that referenced this pull request Oct 11, 2016

src: fix typo in #endif comment
PR-URL: #8989
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Brian White <mscdex@mscdex.net>

MylesBorins added a commit that referenced this pull request Nov 22, 2016

src: fix typo in #endif comment
PR-URL: #8989
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Brian White <mscdex@mscdex.net>

@MylesBorins MylesBorins referenced this pull request Nov 22, 2016

Merged

v4.7.0 proposal #9736

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment