New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add platform specific teams to onboarding-extras #9009

Closed
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
9 participants
@gibfahn
Member

gibfahn commented Oct 10, 2016

Checklist

  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Affected core subsystem(s)

doc

Description of change

This is three separate changes (which can probably be squashed on landing):

EDIT: To clarify, the label changes haven't been done yet. I guess it makes sense to do it as part of the landing process (cc. @Fishrock123 )

1. Add OS/ARCH labels for aix, ppc, and s390:

  • Should be non-controversial, but requires the labels to be created

2. Change solaris tag to smartos:

  • Might make sense as per nodejs/build#500, if the existing labels update (but I defer to @nodejs/platform-solaris )

3. Add teams for platform-specific issues

Members for new teams:

Feel free to volunteer!

Do members of teams need to be collaborators? EDIT: I think the answer is yes

@jasnell

LGTM

@imyller

This comment has been minimized.

Member

imyller commented Oct 11, 2016

Apple has updated branding:

macOS (originally named "Mac OS X" until 2012 and then "OS X" until 2016)

How about also changing os x label to macos (or more generic mac)?

@gibfahn

This comment has been minimized.

Member

gibfahn commented Oct 11, 2016

@imyller macos sounds good to me, added.

@imyller

This comment has been minimized.

Member

imyller commented Oct 11, 2016

Is there interest for adding @nodejs/platform-mac ?

@gibfahn

This comment has been minimized.

Member

gibfahn commented Oct 11, 2016

@imyller I think it makes sense as long as there are macOS specific issues that don't show up on Linux. Edit: Added @nodejs/platform-macos

@gibfahn gibfahn force-pushed the gibfahn:add-teams branch 2 times, most recently Oct 11, 2016

@mhdawson

This comment has been minimized.

Member

mhdawson commented Oct 11, 2016

I think we should also have:

platform-ppc: @mhdawson @gireeshpunathil @gibfahn @bnoordhuis @sxa555 @jbajwa

and add @sxa555 and @jbajwa to: platform-aix and platform-ppc

There is also a doc somewhere that provides guidance on who to cc for issues, we should probably update that to cover these new groups.

@@ -76,10 +77,10 @@ Please use these when possible / appropriate
### Other Labels

* Operating system labels
* `os x`, `windows`, `solaris`
* `macos`, `windows`, `smartos`, `aix`

This comment has been minimized.

@Fishrock123

Fishrock123 Oct 11, 2016

Member

aside: this has not yet been changed

@gibfahn

This comment has been minimized.

Member

gibfahn commented Oct 11, 2016

@mhdawson

I think we should also have: platform-ppc: @mhdawson @gireeshpunathil @gibfahn @bnoordhuis @sxa555 @jbajwa and add @sxa555 and @jbajwa to: platform-aix and platform-ppc

  • Is there a need for a platform-ppc separately from platform-aix? Would that be for ppcBE and ppcLE Linux specific issues? I'm not sure how often that would actually have to be used.
  • I'm pretty sure that people have to be collaborators to be added to teams.

There is also a doc somewhere that provides guidance on who to cc for issues, we should probably update that to cover these new groups.

Assuming you mean https://github.com/nodejs/node/blob/master/doc/onboarding-extras.md#who-to-cc-in-issues, that's covered in this PR.

@misterdjules

LGTM

@jasnell

LGTM

@mhdawson

This comment has been minimized.

Member

mhdawson commented Oct 11, 2016

@gibfahn Linux on P uses ppc and is not related to AIX. platform-ppc (or maybe something better) would be for issues on Linux on P as opposed to AIX.

@mhdawson

This comment has been minimized.

Member

mhdawson commented Oct 11, 2016

@gibfahn I think we have people in teams for WGs who are not collaborators. @mikeal any issue with adding people to the org who are not collaborators so they can be added to a team ?

@mhdawson

This comment has been minimized.

Member

mhdawson commented Oct 11, 2016

@gibfahn yup https://github.com/nodejs/node/blob/master/doc/onboarding-extras.md#who-to-cc-in-issues was that I was thinking about. I should have looked more closely.

@gibfahn

This comment has been minimized.

Member

gibfahn commented Oct 11, 2016

@mhdawson If that's possible then great! I'll update.

@imyller

LGTM

doc: add s390 and ppc architecture labels
Adds `s390` and `ppc` as Arch labels, and `aix` as an OS label.

@gibfahn gibfahn force-pushed the gibfahn:add-teams branch Oct 12, 2016

@gibfahn gibfahn force-pushed the gibfahn:add-teams branch to 93228c3 Oct 12, 2016

@joransiu

This comment has been minimized.

Contributor

joransiu commented Oct 13, 2016

I'd be interested in joining the PPC, AIX and s390 teams.

@jasnell

LGTM

@rvagg rvagg force-pushed the nodejs:master branch 2 times, most recently to 83c7a88 Oct 18, 2016

jasnell added a commit that referenced this pull request Oct 24, 2016

doc: add s390 and ppc architecture labels
Adds `s390` and `ppc` as Arch labels, and `aix` as an OS label.
PR-URL: #9009
Reviewed-By: Julien Gilli <jgilli@nodejs.org>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

jasnell added a commit that referenced this pull request Oct 24, 2016

doc: add teams for platform-specific issues
Specifies teams to cc for platform specific issues

 - Existing teams: @nodejs/platform-arm, @nodejs/platform-freebsd, and
@nodejs/platform-windows
 - New teams: @nodejs/platform-s390, @nodejs/platform-aix
 - Changed name: @nodejs/platform-solaris -> @nodejs/platform-smartos

PR-URL: #9009
Reviewed-By: Julien Gilli <jgilli@nodejs.org>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

jasnell added a commit that referenced this pull request Oct 24, 2016

doc: change solaris tag to smartos
PR-URL: #9009
Reviewed-By: Julien Gilli <jgilli@nodejs.org>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

jasnell added a commit that referenced this pull request Oct 24, 2016

doc: change os x tag to macos
PR-URL: #9009
Reviewed-By: Julien Gilli <jgilli@nodejs.org>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@jasnell

This comment has been minimized.

Member

jasnell commented Oct 24, 2016

Landed in c659c9d...5532a7a

@jasnell jasnell closed this Oct 24, 2016

@gibfahn

This comment has been minimized.

Member

gibfahn commented Oct 24, 2016

@mhdawson I'm getting an error when I try to add someone who isn't a collaborator to a team. I guess gireeshpunathil, joransiu, sxa555, richardlau, jbajwa and john-yan will have to be added to the org (if that's okay, would be good to get confifrmation from @mikeal), which I don't have access to do. I also don't think I can create the aix, ppc, and s390 labels.

@misterdjules I'll leave the changing of @nodejs/platform-solaris -> @nodejs/platform-smartos and the solaris tag to smartos to you.

@imyller I added you to @nodejs/platform-macos , again I don't think I can change the label, maybe @jasnell could do that?

@misterdjules

This comment has been minimized.

Contributor

misterdjules commented Oct 24, 2016

@misterdjules I'll leave the changing of @nodejs/platform-solaris -> @nodejs/platform-smartos and the solaris tag to smartos to you.

Done.

jasnell added a commit that referenced this pull request Oct 24, 2016

doc: add s390 and ppc architecture labels
Adds `s390` and `ppc` as Arch labels, and `aix` as an OS label.
PR-URL: #9009
Reviewed-By: Julien Gilli <jgilli@nodejs.org>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

jasnell added a commit that referenced this pull request Oct 24, 2016

doc: add teams for platform-specific issues
Specifies teams to cc for platform specific issues

 - Existing teams: @nodejs/platform-arm, @nodejs/platform-freebsd, and
@nodejs/platform-windows
 - New teams: @nodejs/platform-s390, @nodejs/platform-aix
 - Changed name: @nodejs/platform-solaris -> @nodejs/platform-smartos

PR-URL: #9009
Reviewed-By: Julien Gilli <jgilli@nodejs.org>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

jasnell added a commit that referenced this pull request Oct 24, 2016

doc: change solaris tag to smartos
PR-URL: #9009
Reviewed-By: Julien Gilli <jgilli@nodejs.org>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

jasnell added a commit that referenced this pull request Oct 24, 2016

doc: change os x tag to macos
PR-URL: #9009
Reviewed-By: Julien Gilli <jgilli@nodejs.org>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@MylesBorins

This comment has been minimized.

Member

MylesBorins commented Nov 17, 2016

as the platform support for v4 and v6 are different I am opting to not land this. @gibfahn please feel free to manually backport

@gibfahn gibfahn deleted the gibfahn:add-teams branch Dec 16, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment