New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test-debugger-pid: Somes fixes that do not change performance #9011

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
9 participants
@larissayvette
Contributor

larissayvette commented Oct 10, 2016

Affected core subsystem(s)

test/test-debugger-pid.js

Description of change

Changes that do not affect how the system functions

@jasnell

LGTM :-)

@lpinca

lpinca approved these changes Oct 10, 2016

LGTM

@mscdex mscdex added the debugger label Oct 10, 2016

@Trott

This comment has been minimized.

Member

Trott commented Oct 11, 2016

LGTM if CI is good.

(Nit: commit message should conform to the CONTRIBUTING.md guidelines. Not a big deal, though, can be fixed by whoever lands the change.)

@larissayvette larissayvette force-pushed the larissayvette:fix-branch branch Oct 11, 2016

@larissayvette

This comment has been minimized.

Contributor

larissayvette commented Oct 11, 2016

@Trott, changes made. I have succeeded in complying the commit message as required

@Trott

This comment has been minimized.

Member

Trott commented Oct 11, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/4464/

Nit: subsystem on commit message should be test and not test-debugger-pid.

@larissayvette larissayvette force-pushed the larissayvette:fix-branch branch to 823f975 Oct 11, 2016

@gibfahn

This comment has been minimized.

Member

gibfahn commented Oct 12, 2016

Looks like CI was entirely green? @Trott You must have a magic touch.

LGTM

@jasnell jasnell self-assigned this Oct 12, 2016

jasnell added a commit that referenced this pull request Oct 12, 2016

test: fixes that do not affect performance
PR-URL: #9011
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@jasnell

This comment has been minimized.

Member

jasnell commented Oct 12, 2016

Landed in 1bc9af8. Thank you @larissayvette!

@jasnell jasnell closed this Oct 12, 2016

jasnell added a commit that referenced this pull request Oct 12, 2016

test: fixes that do not affect performance
PR-URL: #9011
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

MylesBorins added a commit that referenced this pull request Nov 11, 2016

test: fixes that do not affect performance
PR-URL: #9011
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

@MylesBorins MylesBorins referenced this pull request Nov 22, 2016

Merged

v6.9.2 proposal #9735

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment