assert: name anonymous functions #9051

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
5 participants
@maasencioh
Contributor

maasencioh commented Oct 12, 2016

Checklist
  • commit message follows commit guidelines
Description of change

Ref: #8913

@lpinca

lpinca approved these changes Oct 12, 2016

LGTM

lib/assert.js
_throws(true, block, error, message);
};
// EXTENSION! This is annoying to write outside this module.
-assert.doesNotThrow = function(block, /*optional*/error, /*optional*/message) {
+assert.doesNotThrow = function doesNotThrow(block, /*optional*/error, /*optional*/message) {

This comment has been minimized.

@lpinca

lpinca Oct 14, 2016

Member

@maasencioh I think the linter is not happy with this line as it is too long.
Can you please fix this? Thank you.

@lpinca

lpinca Oct 14, 2016

Member

@maasencioh I think the linter is not happy with this line as it is too long.
Can you please fix this? Thank you.

@maasencioh

This comment has been minimized.

Show comment
Hide comment
@maasencioh

maasencioh Oct 17, 2016

Contributor

@lpinca done!

Contributor

maasencioh commented Oct 17, 2016

@lpinca done!

@lpinca

This comment has been minimized.

Show comment
Hide comment

@jasnell jasnell self-assigned this Oct 19, 2016

jasnell added a commit that referenced this pull request Oct 19, 2016

assert: name anonymous functions
Ref: #8913
PR-URL: #9051
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Oct 19, 2016

Member

landed in ef030da. Thank you!

Member

jasnell commented Oct 19, 2016

landed in ef030da. Thank you!

@jasnell jasnell closed this Oct 19, 2016

@maasencioh

This comment has been minimized.

Show comment
Hide comment
@maasencioh

maasencioh Oct 19, 2016

Contributor

Thanks!

Contributor

maasencioh commented Oct 19, 2016

Thanks!

@maasencioh maasencioh deleted the maasencioh:name_assert branch Oct 19, 2016

jasnell added a commit that referenced this pull request Oct 20, 2016

assert: name anonymous functions
Ref: #8913
PR-URL: #9051
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@MylesBorins MylesBorins referenced this pull request in nodejs/Release Nov 17, 2016

Closed

Backporting naming anonymous functions to v6 / v4 #160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment