New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: further improve child_process doc types #9095

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
7 participants
@Ingramz
Contributor

Ingramz commented Oct 14, 2016

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Per stream.md Stream should be lowercase. This probably fixes automatic linking in API docs.

@jasnell

LGTM

@lpinca

lpinca approved these changes Oct 14, 2016

LGTM

@addaleax

LGTM

jasnell added a commit that referenced this pull request Oct 17, 2016

doc: further improve child_process doc types
PR-URL: #9095
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@jasnell

This comment has been minimized.

Member

jasnell commented Oct 17, 2016

Landed in 7f02fec. Thank you!

@jasnell jasnell closed this Oct 17, 2016

@Ingramz Ingramz deleted the Ingramz:patch-1 branch Oct 17, 2016

jasnell added a commit that referenced this pull request Oct 17, 2016

doc: further improve child_process doc types
PR-URL: #9095
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

MylesBorins added a commit that referenced this pull request Nov 11, 2016

doc: further improve child_process doc types
PR-URL: #9095
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

@MylesBorins MylesBorins referenced this pull request Nov 22, 2016

Merged

v6.9.2 proposal #9735

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment