Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
buffer: coerce slice parameters consistenly #9101
Affected core subsystem(s)
Description of change
As shown in #9096, the offset and
This happens because, starting value of the slice is 4 / 3, which is
This patch makes sure that all the offsets are coerced to an integer.
LGTM if CI is ok with it: https://ci.nodejs.org/job/node-test-pull-request/4526/
+1 to considering this a bugfix, too.
CITGM to account for the “but if anything substantial relies on the old behavior” part: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/425