New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix typo (zlib) #9123

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
9 participants
@parambirs
Contributor

parambirs commented Oct 17, 2016

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Fix a typo in documentation for zlib module. Change 'methods with throw an error' to 'methods will throw an error'.

doc: fix typo (zlib)
Change 'methods with throw an error' to 'methods will throw an error'.
@mscdex

This comment has been minimized.

Contributor

mscdex commented Oct 17, 2016

LGTM

@Trott

Trott approved these changes Oct 17, 2016

LGTM

@lpinca

lpinca approved these changes Oct 17, 2016

LGTM

@jasnell

LGTM. This is trivial enough not to have to wait the full 48 hours

jasnell added a commit that referenced this pull request Oct 17, 2016

doc: fix typo in zlib.md
Change 'methods with throw an error' to 'methods will throw an error'.

PR-URL: #9123
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
@jasnell

This comment has been minimized.

Member

jasnell commented Oct 17, 2016

Landed in 1fcd088

@jasnell jasnell closed this Oct 17, 2016

jasnell added a commit that referenced this pull request Oct 17, 2016

doc: fix typo in zlib.md
Change 'methods with throw an error' to 'methods will throw an error'.

PR-URL: #9123
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>

MylesBorins added a commit that referenced this pull request Nov 11, 2016

doc: fix typo in zlib.md
Change 'methods with throw an error' to 'methods will throw an error'.

PR-URL: #9123
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>

@MylesBorins MylesBorins referenced this pull request Nov 22, 2016

Merged

v6.9.2 proposal #9735

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment