Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
streams: fix regression in `unpipe()` #9171
Affected core subsystem(s)
Description of change
Since 2e568d9 there is a bug where unpiping a stream from a readable stream that has
This patch corrects that problem.
Credit for the bug report and the test case go to @niels4. Since it’s a rather big bug, I’ve opened a PR myself. (If you let me know an email address/name in time, I can add you as the git author of the test file.)
Thanks for getting this started. I was just finishing a meeting and then it took me a little bit to figure out where to put the test.
I took some time to change the test case to look similar to the other tests already in place (this one doesn't refer directly to _readableState). Looks like you already have this pull request started, but my changes can be found in this commit
My name is Niels Nielsen, email email@example.com
freebsd 11 stalled, arm7 wheezy and smart os 14 never started
smart os 15 fails are all known flakes
There are two freebsd10 failures related to timers, I do not think they are related to this change
I'm going to go ahead and land the change as this is a pretty big break.