Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
test: fix flaky test-timers-blocking-callback #9198
Affected core subsystem(s)
Description of change
This test was failing on FreeBSD from time to time in the project CI.
This changes the assertion to fire when the timer is more than 100ms
I ran a modified version of this test using 0.10.38 (which has the bug)
This is definitely an improvement, so the changes look good to me. However the test would still be inherently flaky, because there's no guarantee of when the timers will fire regardless of the bug that was fixed by the change that came with this test.
For instance, one recent test failure showed that it took around 1.2 seconds for the test to fail, when in total it should take ~600ms for the test to complete if the process running that program is always on CPU.
In other words, I'd expect these changes to result in this test being less flaky, but still flaky.