Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: remove dangling eslint symlink #9299

Merged
merged 1 commit into from Oct 27, 2016

Conversation

@sam-github
Copy link
Member

commented Oct 26, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

tools

Description of change

The tools/eslint/node_modules/.bin/eslint symlink was unused by node,
but was present, and pointed at a non-existent file. This causes
problems for tooling.

@Trott

@sam-github sam-github added tools and removed tools labels Oct 26, 2016

@Trott
Trott approved these changes Oct 26, 2016
Copy link
Member

left a comment

LGTM.

Not sure what the best way to keep this from happening going forward would be. I guess step one is just more awareness and people calling it out on PRs that update ESLint...

@sam-github

This comment has been minimized.

Copy link
Member Author

commented Oct 26, 2016

@Trott I'm not sure either. How did you create the eslint you committed? What was your sequence? We could probably figure out one that works and document in a README somewhere. Or in the next commit message. You put some effort into your commit to say what you did, but just at a high level.

@jasnell

This comment has been minimized.

Copy link
Member

commented Oct 26, 2016

btw, this one is trivial enough that it shouldn't need to wait the 48 hours to land.

tools: remove dangling eslint symlink
The tools/eslint/node_modules/.bin/eslint symlink was unused by node,
but was present, and pointed at a non-existent file. This causes
problems for tooling.

Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #9299

@sam-github sam-github force-pushed the sam-github:rm-eslint-invalid-symlinks branch to de24c45 Oct 27, 2016

@sam-github sam-github merged commit de24c45 into nodejs:master Oct 27, 2016

@sam-github

This comment has been minimized.

Copy link
Member Author

commented Oct 27, 2016

Landed in de24c45

(edited by @thealphanerd original message accidentally included the issue number not commit)

@sam-github sam-github deleted the sam-github:rm-eslint-invalid-symlinks branch Oct 27, 2016

evanlucas added a commit that referenced this pull request Nov 3, 2016
tools: remove dangling eslint symlink
The tools/eslint/node_modules/.bin/eslint symlink was unused by node,
but was present, and pointed at a non-existent file. This causes
problems for tooling.

Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #9299
MylesBorins added a commit that referenced this pull request Nov 17, 2016
tools: remove dangling eslint symlink
The tools/eslint/node_modules/.bin/eslint symlink was unused by node,
but was present, and pointed at a non-existent file. This causes
problems for tooling.

Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #9299
MylesBorins added a commit that referenced this pull request Nov 17, 2016
tools: remove dangling eslint symlink
The tools/eslint/node_modules/.bin/eslint symlink was unused by node,
but was present, and pointed at a non-existent file. This causes
problems for tooling.

Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #9299
MylesBorins added a commit that referenced this pull request Nov 19, 2016
tools: remove dangling eslint symlink
The tools/eslint/node_modules/.bin/eslint symlink was unused by node,
but was present, and pointed at a non-existent file. This causes
problems for tooling.

Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #9299
This was referenced Nov 22, 2016
@sam-github sam-github referenced this pull request Jan 12, 2017
3 of 3 tasks complete
sam-github added a commit that referenced this pull request Jan 12, 2017
eslint: remove dangling eslint symlink
Reapplication of #9299 since the
symlink was re-added in f44969a.

PR-URL: #10771
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
italoacasas added a commit to italoacasas/node that referenced this pull request Jan 18, 2017
eslint: remove dangling eslint symlink
Reapplication of nodejs#9299 since the
symlink was re-added in f44969a.

PR-URL: nodejs#10771
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
italoacasas added a commit to italoacasas/node that referenced this pull request Jan 23, 2017
eslint: remove dangling eslint symlink
Reapplication of nodejs#9299 since the
symlink was re-added in f44969a.

PR-URL: nodejs#10771
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos added a commit that referenced this pull request Jan 28, 2017
eslint: remove dangling eslint symlink
Reapplication of #9299 since the
symlink was re-added in f44969a.

PR-URL: #10771
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
italoacasas added a commit to italoacasas/node that referenced this pull request Jan 30, 2017
eslint: remove dangling eslint symlink
Reapplication of nodejs#9299 since the
symlink was re-added in f44969a.

PR-URL: nodejs#10771
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
italoacasas added a commit to italoacasas/node that referenced this pull request Jan 30, 2017
eslint: remove dangling eslint symlink
Reapplication of nodejs#9299 since the
symlink was re-added in f44969a.

PR-URL: nodejs#10771
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.