New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

constants: errors -> errno #9349

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
10 participants
@bengl
Member

bengl commented Oct 28, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

constants

Description of change

lib/constants.js was incorrectly copying the constants from the
binding, by copying from contants.os.errors instead of
constants.os.errno.

constants: errors -> errno
lib/constants.js was incorrectly copying the constants from the
binding, by copying from `contants.os.errors` instead of
`constants.os.errno`.
@jasnell

oh, ha! good catch.

['os', 'fs', 'crypto'].forEach((l) => {
Object.keys(binding[l]).forEach((k) => {
if (typeof binding[l][k] === 'object') { //errno and signals

This comment has been minimized.

@lpinca

lpinca Nov 1, 2016

Member

Tiny tiny nit: space after // in the comment.

@lpinca

lpinca Nov 1, 2016

Member

Tiny tiny nit: space after // in the comment.

@lpinca

lpinca approved these changes Nov 1, 2016

@mscdex mscdex removed the constants label Nov 16, 2016

@italoacasas

This comment has been minimized.

Show comment
Hide comment

italoacasas added a commit that referenced this pull request Nov 29, 2016

constants: errors -> errno
lib/constants.js was incorrectly copying the constants from the
binding, by copying from `contants.os.errors` instead of
`constants.os.errno`.

PR-URL: #9349
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Ron Korving <ron@ronkorving.nl>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@italoacasas

This comment has been minimized.

Show comment
Hide comment
@italoacasas

italoacasas Nov 29, 2016

Member

Landed in: edb78aa

Member

italoacasas commented Nov 29, 2016

Landed in: edb78aa

addaleax added a commit that referenced this pull request Dec 5, 2016

constants: errors -> errno
lib/constants.js was incorrectly copying the constants from the
binding, by copying from `contants.os.errors` instead of
`constants.os.errno`.

PR-URL: #9349
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Ron Korving <ron@ronkorving.nl>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@Fishrock123 Fishrock123 referenced this pull request Dec 5, 2016

Merged

v7.2.1 proposal #10127

2 of 2 tasks complete

MylesBorins added a commit that referenced this pull request Dec 20, 2016

constants: errors -> errno
lib/constants.js was incorrectly copying the constants from the
binding, by copying from `contants.os.errors` instead of
`constants.os.errno`.

PR-URL: #9349
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Ron Korving <ron@ronkorving.nl>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

MylesBorins added a commit that referenced this pull request Dec 21, 2016

constants: errors -> errno
lib/constants.js was incorrectly copying the constants from the
binding, by copying from `contants.os.errors` instead of
`constants.os.errno`.

PR-URL: #9349
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Ron Korving <ron@ronkorving.nl>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@MylesBorins MylesBorins referenced this pull request Dec 21, 2016

Merged

V6.9.3 proposal #10394

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment