Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fs: fix link to mkdtemp #9379

Closed
wants to merge 1 commit into from

Conversation

@coderaiser
Copy link
Contributor

commented Oct 31, 2016

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

Documentation of fs module in node v7.0.0.

Description of change

Fixed link to fs.mkdtemp() from fs.mkdtempSync: add options.

@addaleax
Copy link
Member

left a comment

LGTM

@addaleax

This comment has been minimized.

Copy link
Member

commented Oct 31, 2016

Your author name in this commit is given as “coderaiser”. Is that intended or do you prefer to be listed (changelog, git log, AUTHORS file) with some other name? People typically prefer their full name, but ultimately it’s up to you.

@coderaiser

This comment has been minimized.

Copy link
Contributor Author

commented Oct 31, 2016

@addaleax I'm good to be listed with name coderaiser.

[Common System Errors]: errors.html#errors_common_system_errors

This comment has been minimized.

Copy link
@thefourtheye

thefourtheye Oct 31, 2016

Contributor

What is changed here? Newline added at the end?

This comment has been minimized.

Copy link
@addaleax

addaleax Oct 31, 2016

Member

@thefourtheye Yes, that. (Didn’t github use to show this?)

This comment has been minimized.

Copy link
@cjihrig

cjihrig Oct 31, 2016

Contributor

@addaleax I think it would show a red carriage return or something.

This comment has been minimized.

Copy link
@thefourtheye

thefourtheye Oct 31, 2016

Contributor

It doesn't show anything on my browser :'(

This comment has been minimized.

Copy link
@cjihrig

cjihrig Oct 31, 2016

Contributor

Yea mine either. I noticed this same thing earlier. A newline seems to make the most sense.

This comment has been minimized.

Copy link
@princejwesley

princejwesley Oct 31, 2016

Contributor

Sorry, no visible changes to display 😄

This comment has been minimized.

Copy link
@lpinca

lpinca Nov 1, 2016

Member

Yes, it's a LF. GitHub only shows when it's missing.

@lpinca
lpinca approved these changes Nov 1, 2016
@silverwind

This comment has been minimized.

Copy link
Contributor

commented Nov 1, 2016

LGTM, landed in ffa4227.

@silverwind silverwind closed this Nov 1, 2016

silverwind added a commit that referenced this pull request Nov 1, 2016
doc: fs: fix link to mkdtemp
PR-URL: #9379
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
evanlucas added a commit that referenced this pull request Nov 3, 2016
doc: fs: fix link to mkdtemp
PR-URL: #9379
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins added a commit that referenced this pull request Nov 22, 2016
doc: fs: fix link to mkdtemp
PR-URL: #9379
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
@MylesBorins MylesBorins referenced this pull request Nov 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.