New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: throw error in CipherBase::SetAutoPadding #9405

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
6 participants
@fanatid
Contributor

fanatid commented Nov 1, 2016

Checklist
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

crypto

Description of change

Throw error after calling CipherBase#final as in CipherBase::SetAAD, CipherBase::SetAuthTag, CipherBase::GetAuthTag.

@addaleax

This comment has been minimized.

Show comment
Hide comment
@addaleax

addaleax Nov 1, 2016

Member

Tagging this as semver-major because it turns a silent failure (?) into a thrown error.

Member

addaleax commented Nov 1, 2016

Tagging this as semver-major because it turns a silent failure (?) into a thrown error.

@sam-github

This comment has been minimized.

Show comment
Hide comment
@sam-github

sam-github Nov 1, 2016

Member

Needs docs and tests

Member

sam-github commented Nov 1, 2016

Needs docs and tests

@fanatid

This comment has been minimized.

Show comment
Hide comment
@fanatid

fanatid Nov 2, 2016

Contributor

updated

Contributor

fanatid commented Nov 2, 2016

updated

Show outdated Hide outdated test/parallel/test-crypto-cipher-decipher.js
@jasnell

jasnell approved these changes Nov 3, 2016

@cjihrig

cjihrig approved these changes Nov 3, 2016

crypto: throw error in CipherBase::SetAutoPadding
Throw error after calling CipherBase#final
@fanatid

This comment has been minimized.

Show comment
Hide comment
@fanatid

fanatid Feb 7, 2017

Contributor

Rebased and fix lint errors.

Contributor

fanatid commented Feb 7, 2017

Rebased and fix lint errors.

@addaleax

This comment has been minimized.

Show comment
Hide comment
Member

addaleax commented Feb 7, 2017

@addaleax

This comment has been minimized.

Show comment
Hide comment
@addaleax

addaleax Feb 7, 2017

Member

Landed in e90f382, thanks for the PR!

Member

addaleax commented Feb 7, 2017

Landed in e90f382, thanks for the PR!

@addaleax addaleax closed this Feb 7, 2017

addaleax added a commit that referenced this pull request Feb 7, 2017

crypto: throw error in CipherBase::SetAutoPadding
Throw error after calling CipherBase#final

PR-URL: #9405
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

KryDos added a commit to KryDos/node that referenced this pull request Feb 25, 2017

crypto: throw error in CipherBase::SetAutoPadding
Throw error after calling CipherBase#final

PR-URL: nodejs#9405
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

@jasnell jasnell referenced this pull request Apr 4, 2017

Closed

8.0.0 Release Proposal #12220

bnoordhuis added a commit to bnoordhuis/io.js that referenced this pull request Oct 29, 2017

test: add regression test for counter mode warning
The previous commit is a back-port of pull request #13821 to v6.x.
Its regression test does not apply to the v6.x branch (depends on
semver-major pull request #9405) so this commit adds a new test.

Refs: nodejs#13821
Refs: nodejs#9405
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment