src: use ABORT() macro instead of abort() #9613

Merged
merged 1 commit into from Nov 17, 2016

Conversation

Projects
None yet
6 participants
@evanlucas
Member

evanlucas commented Nov 15, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src

Description of change

This makes sure that we dump a backtrace and use raise(SIGABRT) on
Windows.

src: use ABORT() macro instead of abort()
This makes sure that we dump a backtrace and use raise(SIGABRT) on
Windows.

PR-URL: #9613
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

@evanlucas evanlucas closed this Nov 17, 2016

@evanlucas evanlucas deleted the evanlucas:cryptoabort branch Nov 17, 2016

@evanlucas

This comment has been minimized.

Show comment
Hide comment
@evanlucas

evanlucas Nov 17, 2016

Member

Landed in 21826ef. Thanks!

Member

evanlucas commented Nov 17, 2016

Landed in 21826ef. Thanks!

@evanlucas evanlucas merged commit 21826ef into nodejs:master Nov 17, 2016

Fishrock123 added a commit that referenced this pull request Nov 22, 2016

src: use ABORT() macro instead of abort()
This makes sure that we dump a backtrace and use raise(SIGABRT) on
Windows.

PR-URL: #9613
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins

This comment has been minimized.

Show comment
Hide comment
@MylesBorins

MylesBorins Dec 21, 2016

Member

@evanlucas this will need to be manually backported

Member

MylesBorins commented Dec 21, 2016

@evanlucas this will need to be manually backported

@sam-github

This comment has been minimized.

Show comment
Hide comment
@sam-github

sam-github Jan 23, 2017

Member

backported in #10969

Member

sam-github commented Jan 23, 2017

backported in #10969

sam-github added a commit to sam-github/node that referenced this pull request Feb 14, 2017

src: use ABORT() macro instead of abort()
This makes sure that we dump a backtrace and use raise(SIGABRT) on
Windows.

PR-URL: nodejs#9613
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins added a commit that referenced this pull request Feb 21, 2017

src: use ABORT() macro instead of abort()
This makes sure that we dump a backtrace and use raise(SIGABRT) on
Windows.

PR-URL: #9613
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins added a commit that referenced this pull request Feb 22, 2017

src: use ABORT() macro instead of abort()
This makes sure that we dump a backtrace and use raise(SIGABRT) on
Windows.

PR-URL: #9613
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins added a commit that referenced this pull request Mar 7, 2017

src: use ABORT() macro instead of abort()
This makes sure that we dump a backtrace and use raise(SIGABRT) on
Windows.

PR-URL: #9613
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins added a commit that referenced this pull request Mar 9, 2017

src: use ABORT() macro instead of abort()
This makes sure that we dump a backtrace and use raise(SIGABRT) on
Windows.

PR-URL: #9613
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

@MylesBorins MylesBorins referenced this pull request Mar 9, 2017

Merged

v6.10.1 proposal #11759

MylesBorins added a commit that referenced this pull request Mar 9, 2017

src: use ABORT() macro instead of abort()
This makes sure that we dump a backtrace and use raise(SIGABRT) on
Windows.

PR-URL: #9613
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

@MylesBorins MylesBorins referenced this pull request Mar 9, 2017

Merged

v4.8.1 proposal #11760

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment