Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[async_wrap] fix fatal error during destroy() calls #9753
Affected core subsystem(s)
Description of change
Calling JS during GC is a no-no. So intead create a queue of all ids
Removed checking destroy() in test-async-wrap-uid because destroy() can
Missing a reliable test to reproduce the issue that caused the
referenced this pull request
Nov 23, 2016
Fixed things addressed in first review.
@trevnorris We have now seen this bug (same assert in execution.cc) on node v4.5.0, possibly because of our use of weak pointers via the 'weak' module (https://github.com/TooTallNate/node-weak ). Do you think your fix will backport well to node v4.x? Also, just to confirm, your change is not removing weak functionality, I think, so weak pointer functionality from the 'weak' module would still work, at least in node v6 -- is that correct?
@danscales That issue will be with the module
No. It's simply delaying when the callback runs.