Debugger - Filter out the ending of the Module wrapper when using the list command #9773

lholmquist · 2016-11-23T18:54:27Z

Checklist

make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

Affected core subsystem(s)

Debbuger

Description of change

PR for #9768.

When inside the debugger, doing a list(10) on a file with only say 5 lines, would print the end of the module wrapper on the last line.

There is code currently to make sure that the first part of the Module wrapper is filtered out. that is located here: https://github.com/nodejs/node/blob/master/lib/_debugger.js#L1107

The code added filters out the very last line of the lines array, which is the ending of the module wrapper.

I did not add a test for this. I don't believe there was one that tests List anyways. If there needs to be one, i will try and look at the other debugger tests as an example

cjihrig · 2016-11-23T19:05:50Z

Could you provide a test case please.

lholmquist · 2016-11-23T19:09:05Z

sure

lholmquist · 2016-11-28T16:00:21Z

@cjihrig Sorry for the delay(Thanksgiving Holiday), I've added a test case here

lholmquist · 2016-12-05T15:07:03Z

and rebased

cjihrig · 2016-12-05T18:12:42Z

Sign in to view

+const proc = spawn(process.execPath, args, { stdio: 'pipe' });
+proc.stdout.setEncoding('utf8');
+
+var stdout = '';


This can be let.

cjihrig · 2016-12-05T18:12:42Z

Sign in to view

+
+var stdout = '';
+
+var sentCommand = false;


As can these.

cjihrig · 2016-12-05T18:12:42Z

Sign in to view

+proc.stdout.on('data', (data) => {
+  stdout += data;
+  if (!sentCommand && stdout.includes('> 1')) {
+    return sentCommand = true;


Can you split this into two separate lines. Same for the other similar lines below.

cjihrig · 2016-12-05T18:12:42Z

Sign in to view

+    return sentEmpty = true;
+  }
+  if (!sentExit && sentCommand && sentEmpty) {
+    setTimeout(() => {proc.stdin.write('\n\n\n.exit\n\n\n');}, 1);


Why use setImmediate() above and setTimeout() here?

i copied and pasted from another test, so to be honest, thats what happened. is there a preferences for me to switch too

If it works with setImmediate(), or plain synchronous code, that should be preferred over setTimeout().

cjihrig · 2016-12-05T18:12:42Z

Sign in to view

+    false,
+    'the last line of the debugger should not have the module wrapping ending'
+  );
+  console.log(stdout);


Can you remove this.

lholmquist · 2016-12-05T19:12:42Z

@cjihrig ok, i think i got all the changes, and i also rebased against master too

lholmquist · 2016-12-08T15:30:40Z

rebased again

cjihrig

In general, it would be nice if we could reuse the test/debugger/helper-debugger-repl.js file. I'm not sure how feasible it is or not though. Thoughts @nodejs/testing?

cjihrig · 2016-12-08T15:36:39Z

Sign in to view

+process.on('exit', (exitCode) => {
+  assert.strictEqual(exitCode, 0);
+  // No module wrapping at the first line
+  assert.equal(


Can you make this strictEqual()

cjihrig · 2016-12-08T15:36:39Z

Sign in to view

+    'debugger should not have the module wrapper'
+  );
+  // No module wrapping at the end
+  assert.equal(


strictEqual() again please.

cjihrig · 2016-12-08T15:36:39Z

Sign in to view

+  }
+});
+
+process.on('exit', (exitCode) => {


Couldn't this be on the child process close event?

that makes sense

lholmquist · 2016-12-08T15:45:20Z

@cjihrig updated

cjihrig · 2016-12-08T15:50:12Z

Sign in to view

+  }
+});
+
+proc.on('close', (exitCode) => {


Can you assert the signal too (the second argument to the close handler.

added that too. it happens to be null, i was sort of expecting it to not be though

cjihrig · 2016-12-08T16:07:41Z

CI: https://ci.nodejs.org/job/node-test-pull-request/5310/

lholmquist · 2016-12-08T19:27:44Z

looks like some failures, not sure whats going on in those platforms though

lholmquist · 2016-12-08T19:36:40Z

i rebased, maybe there was something missing

cjihrig · 2016-12-09T01:09:52Z

New CI: https://ci.nodejs.org/job/node-test-pull-request/5330/

lance · 2016-12-09T14:16:40Z

Sign in to view

+  }
+});
+
+proc.on('exit', (exitCode, signal) => {


This should probably be wrapped in common.mustCall()

@lance made the update and rebased

cjihrig · 2017-01-20T01:17:55Z

Let's get a fresh CI and see what happens: https://ci.nodejs.org/job/node-test-pull-request/5959/

lholmquist · 2017-01-20T19:27:17Z

i see that the ARM is reporting as failed, but the link to CI looks like it passed.

Also, looks like the smartOS 14-32 isn't failing anymore, but 14-64 still is

cjihrig · 2017-01-20T19:53:12Z

The ARM failure on GitHub can be ignored. If you look at the actual Jenkins link, only SmartOS failed.

TimothyGu · 2017-03-20T00:21:43Z

@cjihrig can this PR be merged or does it need some more work?

cjihrig · 2017-03-20T00:36:57Z

The last time we ran the CI, the test in this PR was failing on SmartOS.

TimothyGu · 2017-03-20T00:41:43Z

The old CI URL seems to have expired. Let's try again then: https://ci.nodejs.org/job/node-test-pull-request/6926/

TimothyGu

CI seems to be passing on SmartOS this time around.

@lholmquist, can you fix this nit and @cjihrig's review comment here (in other words, reverting 8f10635360ffbdd158d3c088a0e19e066ac8cd8c), so we can merge this PR?

TimothyGu · 2017-03-20T01:00:43Z

Sign in to view

+
+  if (!sentEmpty) {
+    setImmediate(() => { proc.stdin.write('list(10)\n'); });
+    sentEmpty = true;


Can you change the variable name to something that is more applicable to this test, like sentList?

@TimothyGu sure

lholmquist · 2017-03-20T13:42:01Z

@TimothyGu @cjihrig I've reverted back that commit, and fixed that small nit. I've also rebased against master too.


        Debugger - Filter out the ending of the Module wrapper when using the…

… list command When doing the list command using a number that is more than the amount lines in that files, ex: list(10), the ending of the Module wrapper was still showing. This removes that line. Fixes: #9768

danbev

Minor nit: the subsystem should perhaps be lib:, and the commit message adhere to the guidelines. (I can make those changes when merging after all reviews have been approved)

danbev · 2017-03-28T10:45:30Z

@cjihrig @TimothyGu Would it be alright if I land this?

gibfahn · 2017-03-28T11:25:58Z

CI 7: https://ci.nodejs.org/job/node-test-commit/8729/

cjihrig · 2017-03-28T12:46:59Z

Looks like there are still related test failures.

danbev · 2017-03-28T12:50:24Z

Looks like there are still related test failures.

I'm running the test on windows to see if I can track down the issue.


        add wait for prompt

This commit attempts to fix a failure that has been reported by CI and that I was able to reproduce locally as well. Will run another CI and see if this takes care of the issue.

danbev · 2017-03-31T13:31:44Z

CI: https://ci.nodejs.org/job/node-test-pull-request/7138/

BridgeAR · 2017-08-26T09:40:40Z

This needs a rebase. @danbev did your commit solve the failure?

lholmquist · 2017-08-28T13:45:16Z

@BridgeAR @cjihrig Since the file that i made changes to is now deleted, does it make sense to still continue this PR?

cjihrig · 2017-08-28T14:08:55Z

I don't think so. I'll close this.

nodejs-github-bot added the debugger label Nov 23, 2016

lholmquist mentioned this pull request Nov 23, 2016

debug list() command showing an extra }); at the end #9768

Closed

lholmquist force-pushed the lholmquist:debugger-outputs-module-wrapper-ending-#9768 branch Nov 28, 2016

lholmquist mentioned this pull request Nov 28, 2016

Node Core Module Exploration - Debugger bucharest-gold/entente#53

Closed

lholmquist force-pushed the lholmquist:debugger-outputs-module-wrapper-ending-#9768 branch Nov 28, 2016

lholmquist force-pushed the lholmquist:debugger-outputs-module-wrapper-ending-#9768 branch 3 times, most recently Nov 29, 2016

cjihrig requested changes Dec 5, 2016

View changes

lholmquist force-pushed the lholmquist:debugger-outputs-module-wrapper-ending-#9768 branch Dec 5, 2016

lholmquist force-pushed the lholmquist:debugger-outputs-module-wrapper-ending-#9768 branch 2 times, most recently Dec 6, 2016

cjihrig requested changes Dec 8, 2016

View changes

lholmquist force-pushed the lholmquist:debugger-outputs-module-wrapper-ending-#9768 branch Dec 8, 2016

cjihrig reviewed Dec 8, 2016

View changes

lholmquist force-pushed the lholmquist:debugger-outputs-module-wrapper-ending-#9768 branch Dec 8, 2016

Fishrock123 mentioned this pull request Dec 8, 2016

attempt-backport still does not work Edit: now working?! nodejs/github-bot#100

Closed

lance requested changes Dec 9, 2016

View changes

lholmquist force-pushed the lholmquist:debugger-outputs-module-wrapper-ending-#9768 branch Jan 18, 2017

nodejs-github-bot added lts-watch-v6.x labels Jan 18, 2017

lholmquist force-pushed the lholmquist:debugger-outputs-module-wrapper-ending-#9768 branch Mar 14, 2017

nodejs-github-bot removed lts-watch-v6.x labels Mar 14, 2017

TimothyGu reviewed Mar 20, 2017

View changes

lholmquist force-pushed the lholmquist:debugger-outputs-module-wrapper-ending-#9768 branch Mar 20, 2017

lholmquist force-pushed the lholmquist:debugger-outputs-module-wrapper-ending-#9768 branch Mar 21, 2017

lholmquist force-pushed the lholmquist:debugger-outputs-module-wrapper-ending-#9768 branch to acbc8bb Mar 22, 2017

danbev approved these changes Mar 27, 2017

View changes

add wait for prompt

Loading status checks…

f5e9b5a

This commit attempts to fix a failure that has been reported by CI and that I was able to reproduce locally as well. Will run another CI and see if this takes care of the issue.

refack force-pushed the nodejs:master branch to fbe946b Apr 14, 2017

cjihrig closed this Aug 28, 2017

nodejs / node

Join GitHub today

Debugger - Filter out the ending of the Module wrapper when using the list command #9773

Debugger - Filter out the ending of the Module wrapper when using the list command #9773

Conversation

lholmquist commented Nov 23, 2016 • edited

Checklist

Affected core subsystem(s)

Description of change

cjihrig commented Nov 23, 2016

lholmquist commented Nov 23, 2016

lholmquist commented Nov 28, 2016

lholmquist commented Dec 5, 2016

This comment has been minimized.

cjihrig Dec 5, 2016 Contributor

This comment has been minimized.

cjihrig Dec 5, 2016 Contributor

This comment has been minimized.

cjihrig Dec 5, 2016 Contributor

This comment has been minimized.

cjihrig Dec 5, 2016 Contributor

This comment has been minimized.

lholmquist Dec 5, 2016 Author Contributor

This comment has been minimized.

cjihrig Dec 5, 2016 Contributor

This comment has been minimized.

cjihrig Dec 5, 2016 Contributor

lholmquist commented Dec 5, 2016

lholmquist commented Dec 8, 2016

cjihrig left a comment

This comment has been minimized.

cjihrig Dec 8, 2016 Contributor

This comment has been minimized.

cjihrig Dec 8, 2016 Contributor

This comment has been minimized.

cjihrig Dec 8, 2016 Contributor

This comment has been minimized.

lholmquist Dec 8, 2016 Author Contributor

lholmquist commented Dec 8, 2016

This comment has been minimized.

cjihrig Dec 8, 2016 Contributor

This comment has been minimized.

lholmquist Dec 8, 2016 Author Contributor

cjihrig commented Dec 8, 2016

lholmquist commented Dec 8, 2016

lholmquist commented Dec 8, 2016

cjihrig commented Dec 9, 2016

This comment has been minimized.

lance Dec 9, 2016 Member

This comment has been minimized.

lholmquist Dec 9, 2016 Author Contributor

cjihrig commented Jan 20, 2017

lholmquist commented Jan 20, 2017

cjihrig commented Jan 20, 2017

TimothyGu commented Mar 20, 2017

cjihrig commented Mar 20, 2017

TimothyGu commented Mar 20, 2017

TimothyGu left a comment

This comment has been minimized.

TimothyGu Mar 20, 2017 Member

This comment has been minimized.

lholmquist Mar 20, 2017 Author Contributor

lholmquist commented Mar 20, 2017

danbev left a comment • edited

danbev commented Mar 28, 2017

gibfahn commented Mar 28, 2017

cjihrig commented Mar 28, 2017

danbev commented Mar 28, 2017

danbev commented Mar 31, 2017

BridgeAR commented Aug 26, 2017

lholmquist commented Aug 28, 2017

cjihrig commented Aug 28, 2017

lholmquist commented Nov 23, 2016 •

edited

danbev left a comment •

edited